Skip to content
This repository has been archived by the owner on Feb 13, 2020. It is now read-only.

Rails server could not be killed #359

Open
smythey21 opened this issue Feb 19, 2016 · 0 comments
Open

Rails server could not be killed #359

smythey21 opened this issue Feb 19, 2016 · 0 comments

Comments

@smythey21
Copy link

After running my rspec tests through sauce_ruby it looks like my rails server isn't killed properly, which means the next test I run will fail (unless I find the PID of the server and kill it, which isn't hard just kind of annoying).

E, [2016-02-19T17:36:14.470000 #48154] ERROR -- : 14802 - Rails server could not be killed. Did it fail to start?

Finished in 2 minutes 32.1 seconds (files took 14.95 seconds to load)
1 example, 0 failures

Randomized with seed 54956

ArgumentError: wrong number of arguments (2 for 1)
            stop at /Users/kevinsmyth/.rbenv/versions/jruby-9.0.4.0/lib/ruby/gems/shared/gems/childprocess-0.5.9/lib/childprocess/jruby/process.rb:82
  block in start at /Users/kevinsmyth/.rbenv/versions/jruby-9.0.4.0/lib/ruby/gems/shared/gems/sauce-3.7.1/lib/sauce/utilities/rails_server.rb:82

I tracked it down to this line and this line. According to the latest version of childprocess, stop only takes one optional parameter (a timeout).

I will submit a PR shortly to address this. Please let me know if I'm missing anything else here. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant