Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test coverage for rotate, zoom and reset of 3D model #15

Open
koebel opened this issue Apr 17, 2024 · 2 comments
Open

E2E test coverage for rotate, zoom and reset of 3D model #15

koebel opened this issue Apr 17, 2024 · 2 comments

Comments

@koebel
Copy link
Contributor

koebel commented Apr 17, 2024

add E2E test coverage for rotate, zoom and reset of 3D model

  • research if it's possible to do assertions related to size and position of the model (camera angle and distance between camera and model)
  • if so, add test coverage for this

Previously, these steps had been defined in the Scenario for testing these aspects:

# rotate, zoom and reset 3D model
When the user rotates the model
And the user zooms into the model
Then the size and position of the 3D model should be changed accordingly
When the user resets the viewport
Then the 3D model should be display in the default size and position

When steps in the scenario above were previously implemented in this PR, but removed in these commits because of lacking implementation of assertion in Then steps:

@koebel koebel mentioned this issue Apr 17, 2024
3 tasks
@koebel
Copy link
Contributor Author

koebel commented Apr 17, 2024

see also this comment about some of the challenges that were faced when trying to implement this previously: #12 (comment)

@koebel
Copy link
Contributor Author

koebel commented May 20, 2024

Amrita has been suggesting to do the assertion with screenshots, see comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant