Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan next release #215

Closed
SethTisue opened this issue Mar 15, 2022 · 13 comments
Closed

Plan next release #215

SethTisue opened this issue Mar 15, 2022 · 13 comments

Comments

@SethTisue
Copy link
Member

What should the version number be? 1.0.3? 1.1.0?

@armanbilge
Copy link

I understand the publishing org changed in #205?

To me it seems like that will require a package name change and a breaking version bump to 2.0.0 to avoid classpath problems.

@SethTisue
Copy link
Member Author

@eed3si9n have other sbt plugins that have changed publishing orgs also changed package names...?

@armanbilge
Copy link

armanbilge commented Mar 15, 2022

sbt-pgp didn't: https://github.com/sbt/sbt-pgp/releases/tag/v2.1.2

IDK. sbt-git seems like a foundational plugin that might power versioning plugins, gh-pages publishing plugins, what have you. Seems ripe for triangle diamond :) dependencies.

@eed3si9n
Copy link
Member

It's a mix. I imagine that some projects are more comfortable using original authors domain as package names because we know them personally while others might opt for more neutral package name for consistency etc? Here are non-exhaustive list:

@raboof
Copy link
Collaborator

raboof commented Mar 16, 2022

I understand the publishing org changed in #205?

To me it seems like that will require a package name change (...) to avoid classpath problems.

That's a great point, let's discuss that separately in #216

and a breaking version bump to 2.0.0

Since the groupId changed I don't think we strictly need to, but I agree it might be nice.

@armanbilge
Copy link

armanbilge commented Mar 16, 2022

Re the version bump: since Scala Steward knows about the group id change, downstreams will receive PRs updating them per usual. So a version bump is important to communicate this breaking change IMO. Edit/clarification: breaking change, if we change the package.

@armanbilge
Copy link

Sorry to be annoying, but any ideas how we can get unblocked? #218 is one way forward. Another way forward is to not care about eviction problems and plunge ahead of course :) all other ideas proposed so far require reviving the old group id and publication credentials.

@SethTisue
Copy link
Member Author

#218 seems fine to me. Anyone strongly object to taking that path?

@raboof
Copy link
Collaborator

raboof commented Mar 22, 2022

Okay, so our options are:

I'm also OK with the first option (and its consequence). If no-one objects let's go for that.

@armanbilge
Copy link

Cool, seems the way forward is #218 and release 2.0.0. Thanks all!

@SethTisue
Copy link
Member Author

tagged https://github.com/sbt/sbt-git/releases/tag/v2.0.0

publish job https://github.com/sbt/sbt-git/actions/runs/2059270141

artifacts are on their way to Maven Central

@armanbilge
Copy link

Thank you!!!

@SethTisue
Copy link
Member Author

Thank you Eugene, Arnout, Arman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants