-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan next release #215
Comments
I understand the publishing org changed in #205? To me it seems like that will require a package name change and a breaking version bump to 2.0.0 to avoid classpath problems. |
@eed3si9n have other sbt plugins that have changed publishing orgs also changed package names...? |
sbt-pgp didn't: https://github.com/sbt/sbt-pgp/releases/tag/v2.1.2 IDK. sbt-git seems like a foundational plugin that might power versioning plugins, gh-pages publishing plugins, what have you. Seems ripe for |
That's a great point, let's discuss that separately in #216
Since the groupId changed I don't think we strictly need to, but I agree it might be nice. |
Re the version bump: since Scala Steward knows about the group id change, downstreams will receive PRs updating them per usual. So a version bump is important to communicate this breaking change IMO. Edit/clarification: breaking change, if we change the package. |
Sorry to be annoying, but any ideas how we can get unblocked? #218 is one way forward. Another way forward is to not care about eviction problems and plunge ahead of course :) all other ideas proposed so far require reviving the old group id and publication credentials. |
#218 seems fine to me. Anyone strongly object to taking that path? |
Okay, so our options are:
I'm also OK with the first option (and its consequence). If no-one objects let's go for that. |
Cool, seems the way forward is #218 and release 2.0.0. Thanks all! |
tagged https://github.com/sbt/sbt-git/releases/tag/v2.0.0 publish job https://github.com/sbt/sbt-git/actions/runs/2059270141 artifacts are on their way to Maven Central |
Thank you!!! |
Thank you Eugene, Arnout, Arman |
What should the version number be? 1.0.3? 1.1.0?
The text was updated successfully, but these errors were encountered: