Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget release Github Action broken #826

Open
jo-chemla opened this issue Oct 21, 2024 · 2 comments
Open

Winget release Github Action broken #826

jo-chemla opened this issue Oct 21, 2024 · 2 comments

Comments

@jo-chemla
Copy link

Hi there, just saw you use winget-releaser@v2 github action to push new releases to winget-pkgs. It seems that the action is broken. There was already a thread on the same topic back in May here #669 that was then resolved.

Looking at the action definition with package identifier, installers-regex and token, I don't see what could be the issue. Maybe the action is running before the releases appear on github release? It seems that it is the url that is not passed properly since the action logs state an empty url list:

  Executing command: java -jar komac.jar update --id 'schollz.croc' --version 10.0.13 --urls '' --submit
  CI environment detected! Komac will throw errors instead of prompting on invalid input
  Latest version of schollz.croc: 10.0.12
  Installer URL cannot be blank on http://localhost
  node:internal/errors:984
    const err = new Error(message);
@schollz
Copy link
Owner

schollz commented Nov 8, 2024

would accept PR

@jo-chemla
Copy link
Author

After looking through it, I'm not exactly sure what has changed since the winget-releaser@v2 action worked. The winget.yml has not been recently updated, and the recent deploy.yml and ci.yml updates seem minor.

It would be helpful to list a few potential changes to have this action work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants