Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean config params doesn't work when set using ENVs #126

Open
kapone89 opened this issue Apr 5, 2023 · 0 comments
Open

Boolean config params doesn't work when set using ENVs #126

kapone89 opened this issue Apr 5, 2023 · 0 comments

Comments

@kapone89
Copy link

kapone89 commented Apr 5, 2023

Boolean config params set using ENVs, like

SCOUT_CORE_AGENT_DOWNLOAD=false
SCOUT_CORE_AGENT_LAUNCH=false

Doesn't work, because they are parsed as strings. So e.g. here
https://github.com/scoutapp/scout_apm_elixir/blob/master/lib/scout_apm/core/agent_manager.ex#L53
There will be "false" string and !!"false" is true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant