Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to execute block with inspector #166

Open
lightsing opened this issue Feb 25, 2025 · 1 comment
Open

Add method to execute block with inspector #166

lightsing opened this issue Feb 25, 2025 · 1 comment

Comments

@lightsing
Copy link
Member

Describe the feature

Current usage:

ScrollExecutorProvider::new(chain_spec)
    .executor(CacheDB::new(db))
    .execute(block)

Could not find an entry fro execute the block with an inspector that implements revm::Inspector trait.

Usage in revm:

EvmBuilder::default()
    .with_external_context(inspector)
    .append_handler_register(inspector_handle_register)

Additional context

No response

@frisitano
Copy link
Collaborator

I've started an experiment to implement this on the following branch https://github.com/scroll-tech/reth/tree/feat/scroll-executor-inspector. We ran into some ownership issues and I've not got time to fix them right now but this is a potential direction we can consider. I think the problem we have is that the strategy takes ownership of the database which is also required by the inspector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants