Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UncheckedExtrinsicV4 to V5 #810

Open
Niederb opened this issue Nov 5, 2024 · 1 comment · May be fixed by #816
Open

Upgrade UncheckedExtrinsicV4 to V5 #810

Niederb opened this issue Nov 5, 2024 · 1 comment · May be fixed by #816
Assignees
Labels
Q5-involved Will take some time to fix this Stay-up-to-date

Comments

@Niederb
Copy link
Contributor

Niederb commented Nov 5, 2024

Currently the nightly build is failing due to usage of two deprecated types.

  • sp_runtime::traits::Extrinsic
  • sp_runtime::traits::Extrinsic::SignaturePayload

Additionally it seems the SignedExtra type was removed

  • solochain_template_runtime::SignedExtra
@haerdib haerdib self-assigned this Jan 21, 2025
@haerdib
Copy link
Contributor

haerdib commented Jan 21, 2025

ExtrinsicVersion was updated to Version 5:

I think the following must be done to close this task:

  • Check if a simplified, self-defined Extrinsic is still needed or not (heavily dependent on the extrinsic_params.rs definitions)
  • Deprecate the ExtrinsicV4 type
  • : Introduce the ExtrinsicV5 type, by either (depending on the findings above):
    • introduce a new simplified V5 type
    • reexport the one from Parity, and make the V5 type the standard one.

@haerdib haerdib changed the title Remove usage of deprecated types Upgrade UncheckedExtrinsicV4 to V5 Jan 21, 2025
@haerdib haerdib added Q5-involved Will take some time to fix this Stay-up-to-date labels Jan 21, 2025
@haerdib haerdib linked a pull request Jan 31, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Q5-involved Will take some time to fix this Stay-up-to-date
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants