Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): adopt scientific python deprecation schedule #1768

Merged
merged 44 commits into from
Feb 18, 2025

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Nov 15, 2024

This PR forces us to adopt the scientific python deprecation schedule as much as possible. It also cleans up our use of spmatrix/sparray because of the bumping of scipy.sparse so that handling sparray is always done via a concrete class

@ilan-gold ilan-gold mentioned this pull request Nov 15, 2024
3 tasks
@ilan-gold ilan-gold added this to the 0.12.0 milestone Nov 15, 2024
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (7fc66bb) to head (8b5048e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/_core/merge.py 95.65% 1 Missing ⚠️
src/anndata/tests/helpers.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
- Coverage   83.84%   83.67%   -0.17%     
==========================================
  Files          41       40       -1     
  Lines        6288     6242      -46     
==========================================
- Hits         5272     5223      -49     
- Misses       1016     1019       +3     
Files with missing lines Coverage Δ
src/anndata/__init__.py 100.00% <100.00%> (ø)
src/anndata/_core/aligned_mapping.py 93.41% <100.00%> (-0.03%) ⬇️
src/anndata/_core/anndata.py 82.61% <100.00%> (ø)
src/anndata/_core/index.py 93.60% <100.00%> (ø)
src/anndata/_core/raw.py 75.88% <100.00%> (ø)
src/anndata/_core/sparse_dataset.py 92.14% <100.00%> (ø)
src/anndata/_core/storage.py 100.00% <100.00%> (ø)
src/anndata/_io/h5ad.py 92.68% <ø> (ø)
src/anndata/_io/specs/lazy_methods.py 97.80% <ø> (ø)
src/anndata/_io/specs/methods.py 88.36% <100.00%> (ø)
... and 8 more

@ilan-gold ilan-gold marked this pull request as ready for review February 3, 2025 10:22
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! So many simplifications. I have a few minor questions and nitpicks apart from #1768 (comment), that’s all.

@ilan-gold ilan-gold enabled auto-merge (squash) February 18, 2025 10:51
@ilan-gold ilan-gold merged commit 3a08892 into main Feb 18, 2025
15 checks passed
@ilan-gold ilan-gold deleted the ig/scientific_python_deprecation_schedule branch February 18, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(chore): clean up use of spmatrix and sparray
2 participants