Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): bound sphinx due to autodoc incompat #1865

Merged
merged 1 commit into from
Feb 19, 2025
Merged

(fix): bound sphinx due to autodoc incompat #1865

merged 1 commit into from
Feb 19, 2025

Conversation

ilan-gold
Copy link
Contributor

  • Closes #
  • Tests added
  • Release note added (or unnecessary)

@ilan-gold ilan-gold added this to the 0.11.4 milestone Feb 19, 2025
@ilan-gold ilan-gold enabled auto-merge (squash) February 19, 2025 13:44
@ilan-gold ilan-gold changed the title (fix): bound sphinx (fix): bound sphinx due to autodoc incompat Feb 19, 2025
@ilan-gold ilan-gold mentioned this pull request Feb 19, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.67%. Comparing base (3a08892) to head (4edb393).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1865      +/-   ##
==========================================
- Coverage   86.11%   83.67%   -2.44%     
==========================================
  Files          40       40              
  Lines        6242     6242              
==========================================
- Hits         5375     5223     -152     
- Misses        867     1019     +152

see 8 files with indirect coverage changes

@ilan-gold ilan-gold merged commit 935cdf2 into main Feb 19, 2025
19 checks passed
@ilan-gold ilan-gold deleted the ig/fix_sphinx branch February 19, 2025 14:13
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Feb 19, 2025
@ilan-gold @meeseeksmachine
Backport PR scverse#1865: (fix): bound sphinx due to autodoc incompat
132ba56
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 19, 2025
Merged
ilan-gold added a commit that referenced this pull request Feb 19, 2025
@meeseeksmachine @ilan-gold
Backport PR #1865: (fix): bound sphinx due to autodoc incompat (#1867)
1cd331d 
Co-authored-by: Ilan Gold <[email protected]>
@flying-sheep
Copy link
Member

Too quick haha, s-a-t 3.1.0 has the fix

flying-sheep added a commit that referenced this pull request Feb 19, 2025
@flying-sheep
Revert "(fix): bound sphinx (#1865)"
1b23c58 
This reverts commit 935cdf2.
@flying-sheep flying-sheep mentioned this pull request Feb 19, 2025
Merged
@ilan-gold
Copy link
Contributor Author

Amazing

ilan-gold pushed a commit that referenced this pull request Feb 23, 2025
@flying-sheep
Revert "(fix): bound sphinx due to autodoc incompat" (#1868)
cea85f6 
* Revert "(fix): bound sphinx (#1865)"

This reverts commit 935cdf2.

* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip-gpu-ci
Projects
None yet
Milestone
0.11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ilan-gold @flying-sheep