(perf): remove out of core median in normalize_total #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3379 +/- ##
==========================================
- Coverage 75.44% 75.44% -0.01%
==========================================
Files 113 113
Lines 13250 13248 -2
==========================================
- Hits 9997 9995 -2
Misses 3253 3253
|
|
Fair enough. Can this blow up? I.e. is |
|
So I did some testing with 1Billion cells. 1Billion cells at 64bit are roughly 8GB. The median costs another 8GB. Thats roughly 16GB. I dont think 16GB of Ram is an issue for someone that analyses 1Billion cells. |
|
Why is this for the 1.12 milestone? |
flying-sheep
changed the title
|
probably because no 1.11.1 milestone existed for a bit (my fault, I’ll be cleaner about this in the future) |
ilan-gold
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing counts per cell for
normalize_totalleads to better performance.