Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate if there are any broken multipart uploads to S3 on purge stage #4035

Open
Tracked by #21528
karol-kokoszka opened this issue Sep 16, 2024 · 1 comment
Open
Tracked by #21528
Labels

Comments

@karol-kokoszka
Copy link
Collaborator

karol-kokoszka commented Sep 16, 2024

There is a possibility that multipart upload to S3 is broken/interrupted.

In such a situation, these mutlipart uploads should be aborted.
https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpu-abort-incomplete-mpu-lifecycle-config.html

Multipart uploads abort can be delegated to RClone by calling to clean them up https://rclone.org/s3/#cleanup

We need to add the cleanup to purge stage of the backup task.

Update:
We can extend the S3 bucket setup guide to include LCM for backup buckets, so that it's delegated to S3.
https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpu-abort-incomplete-mpu-lifecycle-config.html

@karol-kokoszka
Copy link
Collaborator Author

From refinement.

Worth to try reproducing it, by starting the upload of backup that has SSTables available for multipart upload in Scylla Manager (size must be greater that 250 Mb) and killing the agents during the upload.
Later on, there is an API of S3 available that can be used to list pending multipart uploads.
https://docs.aws.amazon.com/cli/latest/reference/s3api/list-multipart-uploads.html

The way to go with this issue may be just an information added to the documentation about multipart upload life-cycle that can be attached to the backup bucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant