Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Metadata for capture sets (multiple captures making up an amp) #305

Open
loki42 opened this issue Sep 8, 2023 · 1 comment
Open
Labels
enhancement New feature or request priority:low Low-priority issues

Comments

@loki42
Copy link

loki42 commented Sep 8, 2023

Currently on sites like tone hunt captures are organised in groups for example 6 captures of different control settings for a single amp, but there is no metadata standard for that. If UIs are to use that information they need it in a standard form.

For Beebo/Hector I am currently using this format, I am happy to change this before it is more widely distributed.

{'amp_brand': 'Laney',
'amp_model': 'VC30',
'amp_year': '2003',
'captured_by': 'Poly Effects'
'control_names': ['channel', 'drive knob'],
'controls': [['normal', 'drive'], ['low', 'mid', 'high']],
'file_names': ['Laney-VC30-channel-normal-drive_knob-low.nam',
'Laney-VC30-channel-normal-drive_knob-mid.nam',
'Laney-VC30-channel-normal-drive_knob-high.nam',
'Laney-VC30-channel-drive-drive_knob-mid.nam'],
'includes_cab': False,
'long_description': 'Small Laney combo, sounds a bit voxish.',
'num_controls': 2,
'tags': ['combo', ' guitar']}

It's just a JSON file, so we can add additional stuff but this covers most of what we need for the Beebo / Hector UI so it might be handy for others. I'm also including an amp.jpeg in the directory, along with the metadata.json

@loki42 loki42 added enhancement New feature or request priority:low Low-priority issues unread This issue is new and hasn't been seen by the maintainers yet labels Sep 8, 2023
@sdatkinson
Copy link
Owner

Apologies for the very long wait on this one.

As you're already aware, .nam files are readable as JSON files, and I'm happy to keep it that way since it's ncie and conducive to easy customization, including what you've done above.

But beyond this, with #419, I'm including an other_metadata kwarg to .export(). If you've got your own trainer code that you want to fill this in automatically, you can do so by adding additional extensions to the ones demonstrated in #420.

I'm not quite at a place where I'm keen to implement your spec into this repo per se. If I add much more complexity to the trainer, it will likely be as a separate package (i.e. spin off the train module), and this package will retain the more "core" code.

@sdatkinson sdatkinson removed the unread This issue is new and hasn't been seen by the maintainers yet label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low-priority issues
Projects
None yet
Development

No branches or pull requests

2 participants