Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] FLAC support to decrease file sizes #352

Closed
38github opened this issue Jan 5, 2024 · 4 comments
Closed

[FEATURE] FLAC support to decrease file sizes #352

38github opened this issue Jan 5, 2024 · 4 comments
Labels
enhancement New feature or request priority:low Low-priority issues

Comments

@38github
Copy link

38github commented Jan 5, 2024

It can save a lot of storage space and Google Colab's upload speed is slow so this would also help there.

@38github 38github added enhancement New feature or request priority:low Low-priority issues unread This issue is new and hasn't been seen by the maintainers yet labels Jan 5, 2024
@sdatkinson
Copy link
Owner

On one hand, I'm open to loading different audio file formats. At the bottom, the audio loading comes from wavio. First step with this would be to suggest to me an alternative for FLAC.

The issue with Colab though (presumably the simplified trainer) is that I need to be able to tell which of the standardized files are being used so that I can set up training correctly (calibrate latency, do a train/test split that doesn't have data leakage, etc) and I'd need to duplicate the work for these files that aren't actually the exact same, so I'm not really keen on that part--this would be a CLI-only feature (or you'd be responsible for maintaining your own training script--which I'd totally encourage you to look into!)

@sdatkinson sdatkinson removed the unread This issue is new and hasn't been seen by the maintainers yet label Jan 14, 2024
@38github
Copy link
Author

38github commented Sep 28, 2024

Is it possible to create and check the checksums based on the raw audio itself and not the file? E.g. a FLAC file has in its tags checksum like that.

Would https://audiodiff.readthedocs.io/en/latest/ maybe work?

@sdatkinson
Copy link
Owner

That's how it works currently 👍🏻


Coming back to this, I'm not going to implement it because I don't think that it helps the core aim of this repo, which is to:

  1. provide the NAM training code for people to build with, and
  2. demonstrate to people how to do (1)

So the way I see it, loading FLAC files is a separate consideration--in fact, getting the audio data in general is separate (it doesn't even need to be from a file--it could be provided directly from a plug-in calling this code).

At any rate, this should be something that someone could either implement in their own project or extend this project either by forking the repo or writing an extension.

@38github
Copy link
Author

Thank you for the explaination and I can see your point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low-priority issues
Projects
None yet
Development

No branches or pull requests

2 participants