Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Pull Requests API #36

Open
8 tasks done
Minoru opened this issue Nov 2, 2016 · 1 comment
Open
8 tasks done

Implement Pull Requests API #36

Minoru opened this issue Nov 2, 2016 · 1 comment
Milestone
Full-featured imp...

Comments

@Minoru
Copy link
Collaborator

Minoru commented Nov 2, 2016

  • List pull requests
  • Get a single pull request
  • Create a pull request
  • Update a pull request
  • List commits on a pull request
  • List pull requests files
  • Get if a pull request has been merged
  • Merge a pull request (Merge Button)
@Minoru Minoru added this to the Full-featured implementation milestone Nov 2, 2016
@Minoru Minoru closed this as completed Nov 2, 2016
@Minoru
Copy link
Collaborator Author

Minoru commented Nov 3, 2016 •
edited
Loading

Re-opening since there's still stuff to implement:

@Minoru Minoru reopened this Nov 3, 2016
Minoru added a commit that referenced this issue Nov 5, 2016
@Minoru
create_pull_request: required params are funargs
f7a0b75 
GitHub API is forced to pass some of the required parameters through
POST and not the URL because these parameters are too large. We aren't
constrained in this way, though, so we better make all required
parameters actual arguments to our functions.

This change strips us of a way to pass "body", but it will be brought
back by #36.
Minoru added a commit that referenced this issue Dec 16, 2016
@Minoru
Prefix internal options with octo (#36)
70f2a5b
Minoru added a commit that referenced this issue Dec 16, 2016
@Minoru
Make update_pull_request take options again (#36)
33c462b
Minoru added a commit that referenced this issue Dec 26, 2016
@Minoru
Prefix cache_key with octo (#36)
1e0c551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Full-featured implementation
Development

No branches or pull requests
1 participant
@Minoru