Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get defaults from a per-user config #16

Open
rmm-ch opened this issue Dec 19, 2024 · 4 comments
Open

feat: get defaults from a per-user config #16

rmm-ch opened this issue Dec 19, 2024 · 4 comments

Comments

@rmm-ch
Copy link
Collaborator

rmm-ch commented Dec 19, 2024

spoof_metadata = {

or do something more useful than this placeholder spoof_metadata

@vancauwe
Copy link
Contributor

can you specify further this issue? I am not sure I understand what it represents

@rmm-ch
Copy link
Collaborator Author

rmm-ch commented Jan 17, 2025

the sidebar in input_handling gets auto-populated with the same data each time. This needs to be changed:

 spoof_metadata = {
    "latitude": 23.5,
    "longitude": 44,
    "author_email": "[email protected]",
    "date": None,
    "time": None,
}

@rmm-ch
Copy link
Collaborator Author

rmm-ch commented Jan 17, 2025

discussion: we remove the defaults, and the user has to specify all elements before proceeding to run the classifier.

@rmm-ch
Copy link
Collaborator Author

rmm-ch commented Jan 17, 2025

Note: the comment just next to these defaults is:
# an arbitrary set of defaults so testing is less painful...

it may be worth implementing a dev mode /flag that does auto-populate the fields. For now, I'm retiring it, will move forward with the simpler fix.

rmm-ch added a commit that referenced this issue Jan 17, 2025
- resolves #16 by removing the spoof_metadata; now the user should enter
  data
- some strange behaviour with the time coming from the file metadata,
  see #21.

- workflow changed so that now:
  1. the user must fill all fields before the validate button is activated
  2. the user must click validate before the classifier button is activated

- implementation for (1) is handled by adding unique keys to all the
  input elements, and adding `check_inputs_are_set -> bool` to ease
  checking the whole group.
@rmm-ch rmm-ch added this to the UI: input handling milestone Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants