Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #4

Closed
wants to merge 1 commit into from
Closed

Add files via upload #4

wants to merge 1 commit into from

Conversation

delilahmilner
Copy link
Collaborator

No description provided.

@delilahmilner
Copy link
Collaborator Author

Added a file

@olgabot
Copy link
Contributor

olgabot commented Dec 18, 2024

Hi @delilahmilner, thank you so much for your work!

  1. To help us keep track of all the different features across people, next time, can you name the branch something like delilahmilner/featurename, e.g. delilahmilner/bcl2-ced9_p66-cd47_dayhoff?
  2. Re "Q: Where does P66 bind CD47? A: 181-187aa" -- this does apply to the dayhoff dataset, too. From the literature, we know that P66 181-187 amino acids are the parts that mimic CD47. It's exciting that k=5 and k=6 dayhoff k-mers show overlap with known P66-CD47 sequences! For k=5 and k=6, can you show the full raw values of query_intersection_positions and match_intersection_positions ?
  3. Same for BCL2/Ced9 at k=5 and k=6, can you show the full raw values of query_intersection_positions and match_intersection_positions?
  4. I think the next step is fixing the SigSeq bug to deal with non-sequential indices, so we can visualize the alignment between CD47 and P66, can you add that to this PR?

Thank you again!

@delilahmilner delilahmilner deleted the Delilah branch December 18, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants