Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated16file #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

delilahmilner
Copy link
Collaborator

I have updated the file. This updated version contains a function to create the display data table.

Copy link
Collaborator

@mlovci mlovci Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def AlignmentTable(aligmentdatalist1, aligmentName1, aligmentdatalist2, aligmentName2, alphabet):

This function should not need to take parameters in this way, there should be a single object pass for alignment1 and alignment 2. In fact, it may be useful to extract the alignments on the fly from the sigseq objects.

Please review the style guide in PEP8 for conventions on things like CamelCase. modules and functions should be lower_case while classes should be CamelCase

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%%file ShowAlignment.py

This is fine to use during your development (aside from not conforming to PEP8 naming conventions) but you should fix up your notebook to delete this cell and commit show_alignment.py directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants