Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate function (related to visibility) should be removed #225

Open
nsaunders opened this issue Mar 2, 2022 · 5 comments
Open

separate function (related to visibility) should be removed #225

nsaunders opened this issue Mar 2, 2022 · 5 comments

Comments

@nsaunders
Copy link
Contributor

The separate function declared here should be removed.

image

@ddssff
Copy link
Contributor

ddssff commented Mar 2, 2022

Added here: 4221200

@turion
Copy link
Collaborator

turion commented Mar 2, 2022

Ah, so it seems the type signature borderCollapse :: Visibility -> Css is actually wrong? There is a comment here 4221200#diff-a82ec625bccfadbae37e6579b4a63ecadcd99a3090a43478674483df463b4a24R160-R170 describing a cleaner but lengthier alternative. I'd prefer that alternative as well, but it will trigger a major version bump.

@nsaunders
Copy link
Contributor Author

Good find @turion. As you know, naming conflicts have been resolved with "namespacing" before, so that would certainly be an option. On the other hand, could this be resolved with, say, a Collapse type class (similar to global keywords)? If so, I suppose it would still technically break compatibility, but (if I'm thinking about it correctly) existing code should still compile... What do you think?

Copy link

This issue has not seen any activity in a long time. If no further activity occurs, it will be closed after ten weeks.

@turion
Copy link
Collaborator

turion commented Oct 25, 2024

I think a Collapse type class is worth a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants