Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deletion of unauthorized samples via batch upload and log failed samples #1936

Open
NielsGeudens opened this issue Jul 1, 2024 · 0 comments
Labels
datahub belgiumHub project

Comments

@NielsGeudens
Copy link
Collaborator

Context
Currently, when performing a batch upload of samples via a CSV file in an ISA-compliant assay, users encounter an issue if the file contains info for existing samples for which they lack edit permissions. Specifically, if any sample in the batch is unauthorized, the entire upload process is halted, and users must manually adjust the CSV file and reattempt the upload. This process could be time-consuming and frustrating, especially when dealing with large datasets.

Current Behavior

  • Users attempt to batch upload samples via CSV into an assay containing samples.
  • If any sample in the file has insufficient rights for editing, an error is displayed in the model form (as per #1908).
  • The upload process cannot proceed for any samples until the unauthorized samples are removed or permissions are adjusted.

Proposed Enhancement

  1. Delete Button for Unauthorized Samples:
  • Introduce a delete button in the model form that allows users to remove unauthorized samples from the batch upload list.
  • This functionality already exists for authorized samples and should be extended to handle unauthorized samples.
  1. Upload Log for Unauthorized Samples:
  • After a successful upload of the authorized samples, provide a log detailing the samples that were not uploaded due to insufficient permissions.
  • This log should be accessible and easy to review, allowing users to take necessary actions on the unauthorized samples post-upload.
  • The log should include detailed information about each unauthorized sample, such as sample ID and the specific permission issue, to aid in troubleshooting.
@NielsGeudens NielsGeudens added the datahub belgiumHub project label Jul 1, 2024
@github-project-automation github-project-automation bot moved this to Requirements in DataHub Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datahub belgiumHub project
Projects
Status: Requirements
Development

No branches or pull requests

1 participant