Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API json requests (PUTS and POSTS) should check Content-Type rather than Accept #2066

Open
stuzart opened this issue Nov 15, 2024 · 0 comments
Open

API json requests (PUTS and POSTS) should check Content-Type rather than Accept #2066

stuzart opened this issue Nov 15, 2024 · 0 comments
Assignees
@stuzart
Milestone
1.16.0

Comments

@stuzart
Copy link
Member

stuzart commented Nov 15, 2024

currently, it only checks Accept rather than Content-Type, which is expected.

for backwards compatibility it will treat as JSON if either are set to json. Although techinically incorrect, this will avoid current clients breaking and will only affect the weird case of intentionally submitting a html request and expecting a json response.
@stuzart stuzart added this to the 1.16.0 milestone Nov 15, 2024
@stuzart stuzart self-assigned this Nov 15, 2024
@stuzart stuzart moved this to In progress in SEEK 1.16.x Nov 15, 2024
stuzart added a commit that referenced this issue Nov 15, 2024
@stuzart
check the content-type header for json requests #2066
48aed3e 
posts and patches will check for content-type as well as accept. updated any tests that were using only the accept header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuzart stuzart

Labels
None yet
Projects
SEEK 1.16.x
Status: In progress
Milestone
1.16.0
Development

No branches or pull requests
1 participant
@stuzart