Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 LinePoolMixin Error #15

Open
Talyrius opened this issue Jul 28, 2024 · 3 comments
Open

11.0 LinePoolMixin Error #15

Talyrius opened this issue Jul 28, 2024 · 3 comments

Comments

@Talyrius
Copy link

It appears the ObjectPoolMixin was removed with patch 11.0 which broke your LinePoolMixin.

https://github.com/Gethe/wow-ui-source/blob/5a34f68e60458f344a776c3132d4d7431fd248a7/Interface/AddOns/Blizzard_SharedXMLBase/Pools.lua#L102-L109

@greerga
Copy link

greerga commented Aug 26, 2024

Replace the file with:

local function LinePoolFactory(linePool)
    return linePool.parent:CreateLine(nil, linePool.layer, linePool.textureTemplate, linePool.subLayer)
end

function CreateLinePool(parent, layer, subLayer, textureTemplate, resetterFunc)
    local linePool = CreateSecureObjectPool(LinePoolFactory)
    linePool.parent = parent
    linePool.layer = layer
    linePool.subLayer = subLayer
    linePool.textureTemplate = textureTemplate
    return linePool
end

Edit: Securing was just changing "CreateObjectPool" to "CreateSecureObjectPool" fortunately.

@Drudoo
Copy link

Drudoo commented Sep 10, 2024

@greerga Could you explain where to replace this? I tried to fix it in WorldFlightMap/LinePool.lua but that didn't fix the issue.

@greerga
Copy link

greerga commented Sep 11, 2024

@greerga Could you explain where to replace this? I tried to fix it in WorldFlightMap/LinePool.lua but that didn't fix the issue.

Yes, that's the place. I'm not sure there aren't other taint issues in the WorldFlightMap code but it mostly fixed things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants