-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor hard-coded email messages as template files #149
Comments
This is a good idea, I had this same feeling writing the code before. |
lilliputten
added a commit
to lilliputten/dds_registration
that referenced
this issue
Apr 10, 2024
lilliputten
added a commit
to lilliputten/dds_registration
that referenced
this issue
Apr 10, 2024
…gress): passing request parameter to message generation code, added templates for payment invoice, added email helpers.
lilliputten
added a commit
to lilliputten/dds_registration
that referenced
this issue
Apr 10, 2024
lilliputten
added a commit
to lilliputten/dds_registration
that referenced
this issue
Apr 10, 2024
…currencies list from constants instead of literal list, with missed 'USD' value).
lilliputten
added a commit
to lilliputten/dds_registration
that referenced
this issue
Apr 10, 2024
lilliputten
added a commit
to lilliputten/dds_registration
that referenced
this issue
Apr 10, 2024
…egistration invoice event. Cleaned up code.
lilliputten
added a commit
to lilliputten/dds_registration
that referenced
this issue
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All email texts and subjects are hard-coded in the
dds_registration/models.py
.Unless it was done on purpose, they should be refactored in a form of standalone templates (probably with substitutable variables for names, urls, emails).
The text was updated successfully, but these errors were encountered: