Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets file should only be for CSS/JS/Image assets - no Django templates #69

Open
cmutel opened this issue Mar 29, 2024 · 1 comment
Open
Assignees

Comments

@cmutel
Copy link
Contributor

cmutel commented Mar 29, 2024

They are deployed at completely different places, served via different daemons, and have different permission structures on production. Django templates absolutely have to live in the dds_registration/templates (or similar) directory.

@lilliputten
Copy link
Collaborator

lilliputten commented Apr 4, 2024

All the files in the src folder not supposed to be served directly.

Some of them are used to produce compiled script and style resources, some other -- as template parts to build pages and their elements.

Only case when we serve src -- it's in dev mode to use scss django filters (but we can get rid of this at all, to get more simplicity -- it isn't used often).

There are a few solutions possible:

(1) To keep it as is to provide more logical structure for developers (all related components stored together);
(2) to break those logically combined groups apart and store them by server file types -- assets and template sources separately;
(3) to set up 'build' process to copy all those template blocks somewhere to templates folder. Then the src folder become 'clear source' storage, but the complexity of the project setup increased, and as a result, we'll have two copies of these files in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants