Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Automatic translation #8

Open
cbaus opened this issue Jan 7, 2022 · 5 comments
Open

Feature request: Automatic translation #8

cbaus opened this issue Jan 7, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@cbaus
Copy link

cbaus commented Jan 7, 2022

Thank you for this great project and easy installation.

I was wondering if there is a way to automatically translate between two (pre-set) languages when the bot is included in a channel.
We need a feature like the current Kiara slack bot offers so we don't have to click the flags as a reaction.
It would be very helpful if you could add this.

@seratch
Copy link
Owner

seratch commented Jan 7, 2022

Hi @cbaus, thanks for writing in!

However, I'm not planning to add such a feature in the short term. If someone is interested in working on the enhancement or forking this project, I'm happy to be a code reviewer, though.

@cbaus
Copy link
Author

cbaus commented Jan 11, 2022

OK I will work on it now and I can provide a pull request later. Please check the code though as Typescript is not really my favourite language.

In any case, DeepL currently doesn't allow to choose the target language based on the source language. I will therefore need to sometimes translate messages twice. That means translate by default to language 1, and if it was already in language 1, translate to language 2 after receiving the detected language tag. Long messages can be cut to save some API usage. I don't think there is another way unless DeepL changes this behaviour.

@seratch
Copy link
Owner

seratch commented Jan 11, 2022

Hey @cbaus, if you are fine to implement for your own use case, I would recommend forking this project or starting from scratch in your favorite language.

And then, once your folk becomes stable and you would like me to merge the changes in this repo, please reach out to me again. As you know, accepting more functionalities requires more maintenance efforts but I don't have the bandwidth for this project.

Also, many companies use this application in their workspaces. I need to avoid having any drastic and/or breaking changes in this repository. It'd be appreciated if you could understand this.

@cbaus
Copy link
Author

cbaus commented Jan 11, 2022

That are not so many changes but feel free to decide yourself if you want to add it or not.

@seratch
Copy link
Owner

seratch commented Jan 21, 2022

Thanks for sharing your idea and working code!

I will keep this issue open for now but I'm not going to merge your PR at least in the short term. If we receive the same feature requests from more and more developers in the future, I may consider working on this.

@seratch seratch added the enhancement New feature or request label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants