-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script table logic instead of using C++ #5
Comments
2 month after, no update? What about the pull requests I've opened on the pinball-pinedit repo? Thanks |
hello @moleculext please reply to abandonware/pinedit#1 , basically have you tested it ? if yes where ? how ? , I'm just trying keep project alive and organize the lastest sources that pop up on internet . |
You haven't pull request master...moleculext:lua_tables ? |
Hi @sergiomb2, I haven't pull request the branch because it's not ready: I've just wrapped the minimal number of method to re-implement the Tux table with logic in a lua script instead of a C++ files. This issue is just to emphasize and propose a system to create new tables more easily. Using script without need of compiling C++ should let more people to create new tables. What do you think? |
Hi @moleculext , in reply of first comment , hopefully computer does not complain about too many work , so the question if we must recompile all every time that we change one comma , I don't care . I'm not going waste my time, to avoid recompilation of all source , the question in my comment was about the license of the tables , if they have to be spitted , because they have different licenses, but rzr haven't reply so I think we don't have any license problem so we may have all source in same repo . I merged all pr that you send to me, |
@sergiomb2 I think we can keep the two systems (c++ logic and lua logic) in order to keep legacy tables, and then add new tables with lua scripting.
Where are these tables? In rzr repo? |
All tables are in https://github.com/sergiomb2/pinball/tree/master/data but I have not finish the organization , many things are dispersed I still got #1 to finish ... |
rzr repos have 2 branches or something like at least have 2 packages https://github.com/sergiomb2/pinball/tree/pinball-data-extra , I merged all in master . |
I am fully supportive on this, it would help for |
Packaging new tables separately makes it easier to test and share new tables, which is attractive for designers more interested in game design and contributing new tables than maintaining and improving the underlying engine. |
Any preference on scripting engine ? |
Hello,
after reading this comment from @sergiomb2, I agreed that it's not convenient to have to rebuild pinball to add new tables.
Despite tables are dynamic libs, this means that it must be compiled for each platform.
So I would like to be able to avoid the C++ part of table creation. I propose to replace it by a scripting language like LUA.
I've started to prototype this idea on my repo. You can checkout the branch lua_tables: I've cloned the Tux table to a TuxLua table and reimplement the logic in LUA for the proof of concept.
At this time it works, you can play the TuxLua table. The LUA version is 5.3.
The code needs some refactoring and some methods not used in Tux table have to be registered for LUA. Once it's done I can pull request the feature if you're interested.
Feebacks are welcome 😃
Thanks
The text was updated successfully, but these errors were encountered: