Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unnecessary namespace listing #458

Closed
JBBianchi opened this issue Dec 5, 2024 · 0 comments · Fixed by #490
Closed

Prevent unnecessary namespace listing #458

JBBianchi opened this issue Dec 5, 2024 · 0 comments · Fixed by #490
Assignees
@JBBianchi
Labels
app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue type: enhancement New feature or request weight: 2 An issue with a low development impact
Milestone
v1.0.0

Comments

@JBBianchi
Copy link
Member

What would you like to be added:
Avoid listing namespaces when they are not required, namely in a workflow details view.

Why is this needed:
In the workflow details view, when listing the instances of a workflow, the list component currently retrieves the list of namespaces by default. This is typically used to populate a dropdown for filtering entities by namespace.

However, in cases where the namespace is predefined by the workflow definition and fixed, the namespace dropdown is not displayed. In such situations, fetching the list of namespaces is unnecessary and could be avoided to improve efficiency.
@JBBianchi JBBianchi added type: enhancement New feature or request app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue weight: 2 An issue with a low development impact labels Dec 5, 2024
@JBBianchi JBBianchi added this to the v1.0.0 milestone Dec 5, 2024
@JBBianchi JBBianchi self-assigned this Dec 5, 2024
JBBianchi added a commit that referenced this issue Jan 31, 2025
@JBBianchi
fix(Dashboard): disabled unnecessary namespace listing
b3a8d3c 
- Disabled unnecessary namespace listing in the workflow details view

Related to #458

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@JBBianchi JBBianchi mentioned this issue Jan 31, 2025
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Progress Tracker Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JBBianchi JBBianchi

Labels
app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue type: enhancement New feature or request weight: 2 An issue with a low development impact
Projects
Progress Tracker
Status: Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Disabled unnecessary namespace listing in the Dashboard serverlessworkflow/synapse
1 participant
@JBBianchi