Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for GCS #9

Open
william-silversmith opened this issue Jul 14, 2020 · 2 comments
Open

Tests for GCS #9

william-silversmith opened this issue Jul 14, 2020 · 2 comments
Labels
testing Additions or modifications to manual or automated tests.

Comments

@william-silversmith
Copy link
Contributor

william-silversmith commented Jul 14, 2020

Right now I'm sort of getting this tested by proxy via CloudVolume's tests. It's ugly though.

@william-silversmith william-silversmith added the testing Additions or modifications to manual or automated tests. label Jul 14, 2020
@fcollman
Copy link

there is a bug in the current implementation using the latest versions of crc32c cloud-volume and cloud-files.

metadata.py", line 71, in fetch_info
    info = self.cache.download_json(self.meta.join(self.mesh_path, 'info'))
  File "/usr/local/lib/python3.7/site-packages/cloudvolume/cacheservice.py", line 354, in download_json
    res = self.download( [ path ], compress=compress, progress=False )
  File "/usr/local/lib/python3.7/site-packages/cloudvolume/cacheservice.py", line 477, in download
    raise frag['error']
  File "/usr/local/lib/python3.7/site-packages/cloudfiles/cloudfiles.py", line 176, in download
    check_crc32c(path, content, server_hash)
  File "/usr/local/lib/python3.7/site-packages/cloudfiles/cloudfiles.py", line 153, in check_crc32c
    crc = crc32c(content)
  File "/usr/local/lib/python3.7/site-packages/cloudfiles/lib.py", line 155, in crc32c
    return crc32clib.value(binary) # an integer
AttributeError: module 'crc32c' has no attribute 'value'

@william-silversmith
Copy link
Contributor Author

There was an issue with google-resumable-media and google-crc32c where their versions were conflicting with crc32c.

googleapis/google-resumable-media-python#162 (comment)

Can you double check to see if your version of google-crc32c is at 1.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Additions or modifications to manual or automated tests.
Projects
None yet
Development

No branches or pull requests

2 participants