-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground: #9
Comments
cc: @jublo Can you provide a bit more detail on your problem and the browser/OS that you are using Justin? I am not following what you mean here. |
Ubuntu 14.04. with chromium Lets say you have code
When I put my cursor on the lower curly brace, the playground circles/highlights the first brace as its "matching" brace. When you move the cursor off the lower bracket to the code section: the first brace that was circled/highlighted as "matching" stays circled/highlighted. Seems to be an issue with the ACE Editor; however, on the ACE Editor page the "matching brace highlighting" functionality works fine. |
Ah, I see. Yes, that is not something that we implemented. Let me check on the ACE editor version here to confirm that we are current. |
cc: @jublo @jublonet JM, do you happen to have any thoughts? |
Here is the changelog for the delta on the current version of ACE vs the one that we are using:
Don't know whether it will fix this but I will update to the current ACE script so that you can give it a try. |
Doesn't seem to help, I am still seeing the same behavior with v1.2.3 of the ACE editor: Submitted an issue report on the ACE repository if you'd like to follow there ajaxorg/ace#2918 |
Yea, worth a shot. Definitely interesting as on the ACE website the issue does not occur. I will check it out, thanks! |
Interesting, maybe something in our implementation of the editor then. Poke, poke @jublo 😉 @davidvangemeren : David, have any thoughts? |
I've looked/glanced at the code, and apart from an inline reference to an older version of ace ( |
Thank you David @burodepeper! |
@justin-parus We'll (actually, Chris will) look if there's an option to disable the brace-matching for now. It seems to be an issue with a shared session between editors. |
@chrissimpkins Apparently this is hard-coded to "on" right now in Ace. http://stackoverflow.com/a/31825820/486298 |
@jublo thank you very much JM! Can we simply use the linked script and import it after the ace.js import from cdnjs? Is it that simple? |
@chrissimpkins I haven’t tested it, but it might work. Worth trying anyways! :) |
@jublo thanks! |
@chrissimpkins Is this done/implemented? |
Don't believe so @jublo |
When you run the cursor accross a parenthesis or bracket it highlights/circles the matching character but does not remove the highlighting when the cursor is not near the original character anymore.
The text was updated successfully, but these errors were encountered: