Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent resizing in list view #224

Open
juliagoolia opened this issue Sep 5, 2024 · 4 comments
Open

inconsistent resizing in list view #224

juliagoolia opened this issue Sep 5, 2024 · 4 comments

Comments

@juliagoolia
Copy link
Collaborator

if you scroll down through the list view (both desktop and mobile) and open the school cards, sometimes they open consistently, but sometimes (especially if you scroll to the bottom and then expand them as you scroll up) they don't. here's a link to a recording: https://sfbrigade.slack.com/files/U01JYKWN43D/F07L5J83AQ2/rpreplay_final1725567192.mp4

@juliagoolia juliagoolia converted this from a draft issue Sep 5, 2024
@thomhickey
Copy link
Collaborator

Hi @juliagoolia ... seems to work as expected to me and I can't tell from the video which schools you are clicking/tapping on so it's hard to see what the problem is there as well. Happy to fix this once I can reproduce it!

@juliagoolia
Copy link
Collaborator Author

hey @thomhickey thanks for looking into it. if you go to the list view and scroll to the very bottom and expand the last school, what do you see? i have another recording that's too big to upload to github. but if i scroll to the bottom and start expanding schools from the bottom of the list going up, none of them show the "learn more" button.

@thomhickey
Copy link
Collaborator

@juliagoolia yeah I can get it to behave wonky, but it takes some doing. most of what i'm seeing is what you noticed in your other bug that the learn more button doesn't scroll into view always (#226) ... which I have fixed in a branch, but i'm not happy with the heavy lifting that was necessary to fix it so i'm fine tuning the code some more.

@thomhickey
Copy link
Collaborator

hi @juliagoolia ... is this fixed in PR #228 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants