From be15a1cde0a7b44ced194ef17338260ac2af7948 Mon Sep 17 00:00:00 2001
From: Levi Zitting <me@levizitting.com>
Date: Mon, 30 Sep 2024 10:37:04 -0500
Subject: [PATCH 1/2] chore: treat warnings as errors in .NET project

---
 .../MethodConf.Cms.Tests.csproj               |  2 +-
 MethodConf.Cms/MethodConf.Cms.csproj          | 73 ++++++++++---------
 2 files changed, 38 insertions(+), 37 deletions(-)

diff --git a/MethodConf.Cms.Tests/MethodConf.Cms.Tests.csproj b/MethodConf.Cms.Tests/MethodConf.Cms.Tests.csproj
index 25e7bf1..50712a8 100644
--- a/MethodConf.Cms.Tests/MethodConf.Cms.Tests.csproj
+++ b/MethodConf.Cms.Tests/MethodConf.Cms.Tests.csproj
@@ -4,7 +4,7 @@
         <TargetFramework>net8.0</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
-
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
         <IsPackable>false</IsPackable>
         <IsTestProject>true</IsTestProject>
     </PropertyGroup>
diff --git a/MethodConf.Cms/MethodConf.Cms.csproj b/MethodConf.Cms/MethodConf.Cms.csproj
index 486f7b4..c81cfc9 100644
--- a/MethodConf.Cms/MethodConf.Cms.csproj
+++ b/MethodConf.Cms/MethodConf.Cms.csproj
@@ -1,44 +1,45 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
-  <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
-    <UserSecretsId>e32a85f3-3a27-42c5-be7c-975d15ecb122</UserSecretsId>
-    <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
-  </PropertyGroup>
+    <PropertyGroup>
+        <TargetFramework>net8.0</TargetFramework>
+        <ImplicitUsings>enable</ImplicitUsings>
+        <Nullable>enable</Nullable>
+        <UserSecretsId>e32a85f3-3a27-42c5-be7c-975d15ecb122</UserSecretsId>
+        <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="AutoMapper" Version="13.0.1" />
-    <PackageReference Include="FluentResults" Version="3.16.0" />
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.11.0" />
-    <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.7">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
-    <PackageReference Include="Umbraco.Cms" Version="14.2.0" />
-    <PackageReference Include="Umbraco.Community.DeliveryApiExtensions" Version="14.0.0-beta.1" />
-    <PackageReference Include="uSync" Version="14.0.0" />
-  </ItemGroup>
+    <ItemGroup>
+        <PackageReference Include="AutoMapper" Version="13.0.1"/>
+        <PackageReference Include="FluentResults" Version="3.16.0"/>
+        <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.11.0"/>
+        <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.7">
+            <PrivateAssets>all</PrivateAssets>
+            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+        <PackageReference Include="Umbraco.Cms" Version="14.2.0"/>
+        <PackageReference Include="Umbraco.Community.DeliveryApiExtensions" Version="14.0.0-beta.1"/>
+        <PackageReference Include="uSync" Version="14.0.0"/>
+    </ItemGroup>
 
-  <ItemGroup>
-    <!-- Opt-in to app-local ICU to ensure consistent globalization APIs across different platforms -->
-    <PackageReference Include="Microsoft.ICU.ICU4C.Runtime" Version="72.1.0.3" />
-    <RuntimeHostConfigurationOption Include="System.Globalization.AppLocalIcu" Value="72.1.0.3" Condition="$(RuntimeIdentifier.StartsWith('linux')) or $(RuntimeIdentifier.StartsWith('win')) or ('$(RuntimeIdentifier)' == '' and !$([MSBuild]::IsOSPlatform('osx')))" />
-  </ItemGroup>
+    <ItemGroup>
+        <!-- Opt-in to app-local ICU to ensure consistent globalization APIs across different platforms -->
+        <PackageReference Include="Microsoft.ICU.ICU4C.Runtime" Version="72.1.0.3"/>
+        <RuntimeHostConfigurationOption Include="System.Globalization.AppLocalIcu" Value="72.1.0.3" Condition="$(RuntimeIdentifier.StartsWith('linux')) or $(RuntimeIdentifier.StartsWith('win')) or ('$(RuntimeIdentifier)' == '' and !$([MSBuild]::IsOSPlatform('osx')))"/>
+    </ItemGroup>
 
-  <ItemGroup>
-    <Content Include=".dockerignore">
-      <Link>.dockerignore</Link>
-    </Content>
-  </ItemGroup>
+    <ItemGroup>
+        <Content Include=".dockerignore">
+            <Link>.dockerignore</Link>
+        </Content>
+    </ItemGroup>
 
-  <ItemGroup>
-    <Folder Include="Infrastructure\Migrations\" />
-  </ItemGroup>
+    <ItemGroup>
+        <Folder Include="Infrastructure\Migrations\"/>
+    </ItemGroup>
 
-  <PropertyGroup>
-    <!-- Razor files are needed for the backoffice to work correctly -->
-    <CopyRazorGenerateFilesToPublishDirectory>true</CopyRazorGenerateFilesToPublishDirectory>
-  </PropertyGroup>
+    <PropertyGroup>
+        <!-- Razor files are needed for the backoffice to work correctly -->
+        <CopyRazorGenerateFilesToPublishDirectory>true</CopyRazorGenerateFilesToPublishDirectory>
+    </PropertyGroup>
 
 </Project>

From 8185fdcef4a721c685fb38ffe4a47d90f5139704 Mon Sep 17 00:00:00 2001
From: Levi Zitting <me@levizitting.com>
Date: Mon, 30 Sep 2024 10:39:38 -0500
Subject: [PATCH 2/2] chore: set eslint max warnings

---
 frontend/package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/package.json b/frontend/package.json
index ddddbe7..2138ffd 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -6,7 +6,7 @@
         "dev": "next dev",
         "build": "next build",
         "start": "next start",
-        "lint": "next lint",
+        "lint": "next lint --max-warnings 0",
         "lint:fix": "next lint --fix",
         "generate:umbraco-api-client": "tsx generateUmbracoApiClient.ts"
     },