Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with version 3.1.0 #8

Closed
avonderluft opened this issue Jan 5, 2025 · 2 comments · Fixed by #11
Closed

Problems with version 3.1.0 #8

avonderluft opened this issue Jan 5, 2025 · 2 comments · Fixed by #11

Comments

@avonderluft
Copy link
Collaborator

Expected behavior

Creating layout, etc. should work in Admin
Even though all tests are passing -- I reckon we need to add some to expose this.

There may be other issues related to sass, but I haven't confirmed that.

Actual behavior

Textarea fields are not writable in the Admin panel

Steps to reproduce

Create a new Rails 8 project, add Surfer, and proceed to try to create layouts, pages, snippets, etc.

System configuration

Rails version: 8.0.1

CMS version: 3.1.0

Ruby version: 3.4.1

/ @justin808 @Judahmeek @langalex

@avonderluft
Copy link
Collaborator Author

I have confirmed that Surfer 3.0.0 on Rails 7.2.2.1, Ruby 3.4.1 works as expected.
@justin808 - maybe you want to yank gem version 3.1.0 until this gets sorted?

@langalex
Copy link
Contributor

I just added a PR to fix the issue.

Also, it might not have been such a smart idea after all to add Assets.compiled_assets to the gemspec. It looks like the consuming app also runs this code (eat least when trying to use the gem directly from github), but it's only supposed to run as a build step. I could move this into a Rake task (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants