fix test cases

shamaton · Aug 15, 2024 · d81259d · d81259d
1 parent 7155d37
commit d81259d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/internal/decoding/complex_test.go b/internal/decoding/complex_test.go
@@ -56,7 +56,7 @@ func Test_asComplex64(t *testing.T) {
 		},
 		{
 			Name:     "Fixext16.error.i",
-			Data:     []byte{def.Fixext16, byte(def.ComplexTypeCode()), 0, 0, 0, 1},
+			Data:     []byte{def.Fixext16, byte(def.ComplexTypeCode()), 0, 0, 0, 0, 0, 0, 0, 1},
 			Error:    def.ErrTooShortBytes,
 			MethodAs: method,
 		},
@@ -126,7 +126,7 @@ func Test_asComplex128(t *testing.T) {
 		},
 		{
 			Name:     "Fixext16.error.i",
-			Data:     []byte{def.Fixext16, byte(def.ComplexTypeCode()), 0, 0, 0, 1},
+			Data:     []byte{def.Fixext16, byte(def.ComplexTypeCode()), 0, 0, 0, 0, 0, 0, 0, 1},
 			Error:    def.ErrTooShortBytes,
 			MethodAs: method,
 		},

diff --git a/internal/decoding/decoding.go b/internal/decoding/decoding.go
@@ -20,11 +20,11 @@ func Decode(data []byte, v interface{}, asArray bool) error {
 	d := decoder{data: data, asArray: asArray}
 
 	if d.data == nil || len(d.data) < 1 {
-		return fmt.Errorf("data is empty")
+		return def.ErrNoData
 	}
 	rv := reflect.ValueOf(v)
 	if rv.Kind() != reflect.Ptr {
-		return fmt.Errorf("holder must set pointer value. but got: %t", v)
+		return fmt.Errorf("%w. v.(type): %t", def.ErrReceiverNotPointer, v)
 	}
 
 	rv = rv.Elem()
@@ -34,7 +34,7 @@ func Decode(data []byte, v interface{}, asArray bool) error {
 		return err
 	}
 	if len(data) != last {
-		return fmt.Errorf("failed deserialization size=%d, last=%d", len(data), last)
+		return fmt.Errorf("%w size=%d, last=%d", def.ErrHasLeftOver, len(data), last)
 	}
 	return err
 }

diff --git a/internal/decoding/decoding_test.go b/internal/decoding/decoding_test.go
@@ -64,8 +64,17 @@ func TestDecoding(t *testing.T) {
 	t.Run("empty data", func(t *testing.T) {
 		v := new(int)
 		err := Decode(nil, v, false)
-		tu.Error(t, err)
-		tu.Equal(t, err.Error(), "data is empty")
+		tu.IsError(t, err, def.ErrNoData)
+	})
+	t.Run("not pointer", func(t *testing.T) {
+		v := 0
+		err := Decode([]byte{def.PositiveFixIntMax}, v, false)
+		tu.IsError(t, err, def.ErrReceiverNotPointer)
+	})
+	t.Run("left data", func(t *testing.T) {
+		v := new(int)
+		err := Decode([]byte{def.PositiveFixIntMin, 0}, v, false)
+		tu.IsError(t, err, def.ErrHasLeftOver)
 	})
 }