Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quitting in insert mode does not remove lock #111

Open
lukasho opened this issue Mar 1, 2018 · 5 comments
Open

Quitting in insert mode does not remove lock #111

lukasho opened this issue Mar 1, 2018 · 5 comments

Comments

@lukasho
Copy link
Contributor

lukasho commented Mar 1, 2018

When quitting via ctrl-Q in insert mode, the file lock is not removed. I'm not sure if that's intended, but if not I would be glad to fix it to be consistent with quitting in normal mode.

@anfly0
Copy link
Contributor

anfly0 commented Mar 4, 2018

I have verified this.
As far as I can tell there isn't a need for a lock on a file that has been closed.
So in my view it's safe to say that this is not the intended behavior.
@shnupta yea or nay?

@shnupta
Copy link
Owner

shnupta commented Mar 5, 2018

Yea @anfly0 :)

Ctrl-Q should remove any lock on a file. If you've closed the file passed the warnings you shouldn't be intending to keep the file locked.

@anfly0
Copy link
Contributor

anfly0 commented Mar 6, 2018

@lukasho I guess that you still want to fix this?
I'll be happy to help if you need it.

@lukasho
Copy link
Contributor Author

lukasho commented Mar 6, 2018

@shnupta it ended up being a small fix. The issue will still come up in situations where exit() is being called (after an error, for instance).

@shnupta
Copy link
Owner

shnupta commented Aug 25, 2018

Update on this - we should attempt to remove the file lock in situations where exit() is being called as @lukasho mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants