Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Quote Card with [Background Image](https://codepen.io/governorfancypants/pen/elsDc) #123

Closed
shravan20 opened this issue Apr 25, 2021 · 12 comments · Fixed by #172
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days)

Comments

@shravan20
Copy link
Owner

Is your feature request related to a problem? Please describe.
Implementation to have a background image instead of solid colour

Describe the solution you'd like
Implementation of adding a background image as optional instead of solid colour

Additional context
Not just new card, but also with existing cards as well.

@shravan20 shravan20 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days) labels Apr 25, 2021
@shravan20 shravan20 added this to the Release of V2.0 milestone Apr 25, 2021
@Rispectech
Copy link

Rispectech commented Oct 1, 2021

just like #124, we can add another option of a background image with single or gradient color. we can keep images in a folder and the user can traverse through them using the next button with we can implement if the user selects image instead of gradient or single color
so I think both #123 and #124 can be implemented through the same approach

@shravan20
Copy link
Owner Author

Hi @Rispectech
I have assigned both the issues to you!
THank you so much for your time :)

@Rispectech
Copy link

Rispectech commented Oct 3, 2021

sure thanks a lot @shravan20. actually, I was quite busy because of prior arrangements so I think I won't be able to work on this for the next week or 2 most probably. so if u are fine with that then all is good.
but since the project is really impressive I would like to work on it if it isn't taken by anyone else

@shravan20
Copy link
Owner Author

This wont be an issue. Take your time. :)

@isengu
Copy link
Contributor

isengu commented Nov 3, 2021

Hey @Rispectech are you still working on it? If you don't have time i can take up this issue.

@Rispectech
Copy link

Rispectech commented Nov 3, 2021

hey @dolmushcu . i just started working on the issue so i will be grateful if i can get some more time . if i am unable to solve it within the next 2 weeks , you can take the issue .
i think we can go it this way you can do #123 while i can work on #124 . can this work ?
Sorry for the inconvienve . hope you can comply with it . Thank you

@isengu
Copy link
Contributor

isengu commented Nov 3, 2021

Absolutely, i thought i should ask, if you're busy or something i thought i could be helpful. There is no inconvenience. As for the splitting issues, i guess these two issues could be solved with the same approach, so you should take up both. Sorry if my recent comment is a bit indiscreet.

@shravan20
Copy link
Owner Author

Hi @dolmushcu
#124 is a different feature implementation compared to this one. Both will have different approaches. We cannot go with the same approach.

@Rispectech
Copy link

Absolutely, i thought i should ask, if you're busy or something i thought i could be helpful. There is no inconvenience. As for the splitting issues, i guess these two issues could be solved with the same approach, so you should take up both. Sorry if my recent comment is a bit indiscreet.

if that's the case , then please go ahead with the issue because its true that i am a bit busy . Thanks for the help .
and about your comments being indiscreet, i would say it was me who was being disrespectfull since the issue has been sitting for more than a month now so your comment was completely right on the mark . so please go ahead with the issue
again sorry for my behavior

@isengu
Copy link
Contributor

isengu commented Nov 5, 2021

Hi @dolmushcu #124 is a different feature implementation compared to this one. Both will have different approaches. We cannot go with the same approach.

Here is what i thought:
In the file where the themes being specified (src/themes/themes.js), we could pass bg_color values directly. I mean right now # character is being added automaticly assuming every value that passed is hex in the layout file. However if we let people pass quote_color, bg_color... freely, they could be able to pass gradient color and image.

EXP: bg_color: "linear-gradient(to right, #0f2027, #203a43, #2c5364)"
EXP: bg_color: "url('http://example.com/image.png')"
EXP: bg_color: "#fff"

When i mention about same approach i was talking about something like this. What do you think? Does this approach have any drawback?

@isengu
Copy link
Contributor

isengu commented Nov 5, 2021

Absolutely, i thought i should ask, if you're busy or something i thought i could be helpful. There is no inconvenience. As for the splitting issues, i guess these two issues could be solved with the same approach, so you should take up both. Sorry if my recent comment is a bit indiscreet.

if that's the case , then please go ahead with the issue because its true that i am a bit busy . Thanks for the help . and about your comments being indiscreet, i would say it was me who was being disrespectfull since the issue has been sitting for more than a month now so your comment was completely right on the mark . so please go ahead with the issue again sorry for my behavior

i feel like we've been missunderstood eachother, you should work on it if you'll have time and i will open a PR in a month if you haven't yet.

@shravan20
Copy link
Owner Author

Hi @dolmushcu #124 is a different feature implementation compared to this one. Both will have different approaches. We cannot go with the same approach.

Here is what i thought: In the file where the themes being specified (src/themes/themes.js), we could pass bg_color values directly. I mean right now # character is being added automaticly assuming every value that passed is hex in the layout file. However if we let people pass quote_color, bg_color... freely, they could be able to pass gradient color and image.

EXP: bg_color: "linear-gradient(to right, #0f2027, #203a43, #2c5364)" EXP: bg_color: "url('http://example.com/image.png')" EXP: bg_color: "#fff"

When i mention about same approach i was talking about something like this. What do you think? Does this approach have any drawback?

Sounds perfect

@shravan20 shravan20 linked a pull request Dec 22, 2021 that will close this issue
shravan20 pushed a commit that referenced this issue Feb 20, 2022
* Readjustment of socrates layout

* Themes file updated to allow not just hex values but also gradient and url values. Layout file updated accordingly as well as churchill and samuel layouts structure readjusted because of not being useable other then solid color values. In addition, added two new themes for demonstration purpose of gradient and image backgrounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants