-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Quote Card with [Background Image](https://codepen.io/governorfancypants/pen/elsDc) #123
Comments
just like #124, we can add another option of a background image with single or gradient color. we can keep images in a folder and the user can traverse through them using the next button with we can implement if the user selects image instead of gradient or single color |
Hi @Rispectech |
sure thanks a lot @shravan20. actually, I was quite busy because of prior arrangements so I think I won't be able to work on this for the next week or 2 most probably. so if u are fine with that then all is good. |
This wont be an issue. Take your time. :) |
Hey @Rispectech are you still working on it? If you don't have time i can take up this issue. |
hey @dolmushcu . i just started working on the issue so i will be grateful if i can get some more time . if i am unable to solve it within the next 2 weeks , you can take the issue . |
Absolutely, i thought i should ask, if you're busy or something i thought i could be helpful. There is no inconvenience. As for the splitting issues, i guess these two issues could be solved with the same approach, so you should take up both. Sorry if my recent comment is a bit indiscreet. |
Hi @dolmushcu |
if that's the case , then please go ahead with the issue because its true that i am a bit busy . Thanks for the help . |
Here is what i thought: EXP: bg_color: "linear-gradient(to right, #0f2027, #203a43, #2c5364)" When i mention about same approach i was talking about something like this. What do you think? Does this approach have any drawback? |
i feel like we've been missunderstood eachother, you should work on it if you'll have time and i will open a PR in a month if you haven't yet. |
Sounds perfect |
* Readjustment of socrates layout * Themes file updated to allow not just hex values but also gradient and url values. Layout file updated accordingly as well as churchill and samuel layouts structure readjusted because of not being useable other then solid color values. In addition, added two new themes for demonstration purpose of gradient and image backgrounds.
Is your feature request related to a problem? Please describe.
Implementation to have a background image instead of solid colour
Describe the solution you'd like
Implementation of adding a background image as optional instead of solid colour
Additional context
Not just new card, but also with existing cards as well.
The text was updated successfully, but these errors were encountered: