Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wakebox: visible paths should not be absolute #1421

Open
mmjconolly opened this issue Sep 19, 2023 · 3 comments
Open

wakebox: visible paths should not be absolute #1421

mmjconolly opened this issue Sep 19, 2023 · 3 comments

Comments

@mmjconolly
Copy link
Contributor

mmjconolly commented Sep 19, 2023

If a visible files list is provided to wakebox via a spec json containing an absolute path, wakebox itself should error-out.
Currently appears to silently ignore them.

@mmjconolly
Copy link
Contributor Author

and also any other files that are outside the workspace, using ../ within the path names of visible files, though I suspect that's never been a problem outside of hand-crafted wakebox spec files

@mmjconolly
Copy link
Contributor Author

It's possible that people have written build rules that have absolute Paths that point outside the workspace, since they were previously ignored this would be a break in the API

@V-FEXrt
Copy link
Contributor

V-FEXrt commented Oct 11, 2023

It's possible that people have written build rules that have absolute Paths that point outside the workspace, since they were previously ignored this would be a break in the API

There are several steps to get there, but I'd like to eventually make it impossible to construct a path outside of the workspace. That should at least help in this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants