From 0fdc36f0080df31b10fab06517a02516bfc2d58e Mon Sep 17 00:00:00 2001
From: Amit Moryossef <amitmoryossef@gmail.com>
Date: Wed, 31 Jan 2024 09:45:28 +0100
Subject: [PATCH] feat(visualize): add option to not trust the box

---
 ...2e300413x552S22b04418x565S36520420x523.png | Bin 0 -> 2537 bytes
 signwriting/visualizer/test_visualize.py      |  16 +++++++++++++
 signwriting/visualizer/visualize.py           |  21 ++++++++++++++++--
 3 files changed, 35 insertions(+), 2 deletions(-)
 create mode 100644 signwriting/visualizer/test_assets/M500x500S2ff00407x501S1ce20436x535S2e300413x552S22b04418x565S36520420x523.png

diff --git a/signwriting/visualizer/test_assets/M500x500S2ff00407x501S1ce20436x535S2e300413x552S22b04418x565S36520420x523.png b/signwriting/visualizer/test_assets/M500x500S2ff00407x501S1ce20436x535S2e300413x552S22b04418x565S36520420x523.png
new file mode 100644
index 0000000000000000000000000000000000000000..5b75fde23c73203168671e2a11f67ba94e9c4a9c
GIT binary patch
literal 2537
zcmV<F2^RK=P)<h;3K|Lk000e1NJLTq001)p003SH1^@s6j>{~r000TFNkl<Zc%1E=
zdu$ZP8Nh#Y#$ZBh<M?qVjtdkH(vsS(Q|j^xp;C>Kw!uPb5v3BLNoh$c8ugEc5F$ZU
zkfK&iRSKy<P!LTO2q6tbNhxt@>i{K~M;eo)aWKTZY-4=*QQHCAU;mg{dpXW`x4U<K
zRQaUQ-tEqO^Zj;acE6eV?v#k&M3hpKfw{mm;B!D0kO_POGy?U&N#H2(x`@;}s=$M&
zSYVV=qk-=OkD>tp+JIBQd7u>#U^Fn^<hc##2FigAz#b9lil_0nh=}x=fMnoFAZUy|
z3;Y7O9~d5?+z52*{mxeQJ>Y>z^?6N^K&F^GFTnf2e8A_p0vH860bDh@HUlI34F)Iy
znt|)U(?F8viXa2{qXBvw$V@m4@OAWHz6#8Ydxd)3-2f_q(FubA?g3iRPo;Yj(G^TR
z^MFp^Z@{p)!vHD3yQY%+5(Q$bZ<*<GKTibA8l!x5qCsqR?lw2CC~h!79`Ik_Or%F{
z0$_4XxBh25^!d!|=5h2(?imre9_7^(Hxca}{2G|0l$z~Tp8}GA%jn1OcoDhbRjDHb
zl*&PS5wD8Kcf9EG0W*MXU`Kz0Ku_zu20W;g8tFxs5B**Nc-gCA9^@ZrPhq+jB|hLw
z=s|cg4o10^!{%7*MTrlX3{**?J=(}}-W<nzQQ||7mj=(~c$1(xW_wZML-$o@GqgC1
zc^!13ryQ=uhaN8(@i5A*D5VrI4DH;y79Vg4NRNk69^?*l^wiybzz4ttrPOVnO>!>*
zbNr7NB|hK?x`{nK7Cp*0%<+I1B|c!k`8+??LP{xd@;L^12sk4m=Ny!|MSLPs3A_U=
zP)enEQRYUJQnP>p;7^{F8CU!f^yB%l7+rU9@;QpGeLx406R-J9GI}mk4`lQg4Dg`2
ziJRgvpBZLqy`hwP9C!o0*0m^Fiz=m7NBbP5d^+%Za|54_rA$-_xl_-h@6;2~S|*kh
zq5N?4Vuk>v@o1HvZf2`w1bR8O8(12zO2UA=WI&#atL`wBr2{8SWzQ0a1wfnbG3I6o
zunDu)oiG?vX&UgRsq_dQ*U-?@^Y78SMEiWaLHdL-1`I<ll6Rq3AYT9q9YQ1lr9g#&
zXa<(V8zL%<&7dM%*AVo+%NpRDzy$QFj^*{{0rvtA16zTMrc5{brI?>6keFa>Q1=77
z(EBnmJ<ZTw@CM-XiG;9HOq)%1QA*to%tY^;-ECSU&D{Ma;2dxoJ+D6^E~ev3sagOL
z$#qoDDNKKe<)n&;a#GG0J<HIMAqk_DTCJ4&mFe=m=Z9K1Q%a2is?pxc7ewT=b!{lN
z%v0#Sq`h_!7-B7>l)4i=RY?J+ib#e1`cP|`C($5(2?c>6)G|sbKROO!Brron4u_T-
zN-eVj4N?{k1c=?8>CZ&S<PONC*NvJPl6M?%5Ewh)hQ|o=oH@5YB;R<n`y{~r0XIAv
zOh~H~hk$%+&c6d>4Y=Vkz*w#FT1eNjKt2TgA`Yei2{wKru+i3Kth67!)gi#WChuM7
zca5Mufu1?iKtuR|b?8`~Nb{nP(38Jh^y0dpAJb!R(l@{$FGPW`r$3{Ehs1QTvA5`q
zlVP)5l=-0p5PP}|1j6c!1IQxaxWh8T(Nk(SFthv8>&XL9N_`vHj$VavB40xXsk)KR
z_I1HEj8f_$bf0$$0x-*My}+ElE(~*{&49c_@9yw;rPMa`mg3t$xkL_K8RMp2BY{4z
zxELd)=%AsVew?45e__|IU6)p@SaG_bpx{DAMn(|5v>SGN1idutX1oYc(Wh+=Anry7
zqFxWJAU{9<qS)lnp+oJ{rcJw)ot=FJC<&wM84oZodx8Nr6crV{UsqSR0__LgRDs{`
zua^+%?(UW?Tee(DO-*eD7KG@V>H((D-HBL0)&v59kL&B}n?yt!8XBGr1Jto>*|M!W
zcI;T+(9rOv9jdIXtSLP`y&3pQh~ASfKx%<eu3&&!+1c3*)z#IPE#t0Sxl*%j+qNIm
z8^CS37C%F8AT_UDyLM}LcXv-~?c2AnCJ+czVGEf=uZng$gqa`F-Y77~Hg4Q_#4@U(
zq2XLXLBV_IK+#NF3!So+DF!}VvSi6_5oxr_mX?;D27Vf%|6%m9ZZwE4;3rXgQ3Q}V
z6DLkQ*V)<GWetOpl9GP`dw^t<#{xPPQZ^f?+Pr!5Mhm8@s;bHF_tya<Lh{ZAsv>}#
zC&u3pM1tA8a^=dmEMs=>-hCMDqNj%B%LKNEDgR|47z_rFTRI903(o@I3X?YpcmVh%
z`bGQ-@CV>AASD)%XfQ|1%gf)j3@IroIS%|NB+tKrTDe(j%|JZ?l&xRCevfrw)v8s;
z&=I;Z8Rs-ba%b)sH*VaWpn(q`K0MhBaJ%FH{xD_z=Gxx!^75YWuPIZeq~I|?E|Nro
z8J?4qGaR6)sfpIs)=}tiE+=xXv9WQ4^(7-CBMH4moDhiw(-jN`n*dT$dO~W_9O}==
z%F1f9zO=No+(19Q5+adcuGQ4koCOUtY0{)i=t1p7iYH8%(Bp7cS64TqBM%cIkzlG0
z9z57+eOb70VF$3(fo=sXSh#TEXRH&44jmef_N)^l5uRq>EiNvu5Rn!Ukzg<=e!ssF
zc+{4sR;#$>X(mA1ym|AES|=MD8|%~3(wc}N(8z6y1d{?>I&k2?i<UuUWo1`WQ&U@j
zNBV-Pt*xyEBq=GWtFErD$vVGo-MZI_Q}mK!7-Q_x!otGJj*gBR%cv74PBaDrfeYvm
z#9$bh8-V2I=5|}>YHDgK^YZd8FpzNorr*D@c=6&_#dJ3jk+!xr*|cfX+2rKp&QO?+
zj*d=1^78UTM5MjFy?Xle>BoQ{BoZVli~&jmDwZ!_{$gim=NY@<e!pMBj2W?Dnwy)C
z&Ye5=@4#;o4H6TK0lFP{WyXvdM=C2Tw~I(H8cb$pX6xk1lRp5S>JN~ZVQf%~fa=oH
z(!D!(?)+_5R#tl`OlxavyLp;@g5G!R7ZArV1}GU=fc9)}88fxDwbu5-h5iH)aS=OX
z7Zc;+57AL)_8%{b$X%|LyO5!@rx{f~g&C~!Da>G%|0@_ry8ue5iRk~yxT$<aMa5gT
zb1mqVmSm-reKL1VL_Tt9XKdo|g;_{%Y_gNo02B;H51@$NKlz9yH3DB8l<tfHnhIQt
z0VIgozaO+P2I#Bk2=cx_t})mh%@Cmb2p_cF0!-^q5YI3Ms095pD+{C*7jXfD0>%K%
zL;v`p4VW_!AR->80CrJIEdYWd^4GX1bRqu(&ux^M<cH`T00000NkvXXu0mjf67Q{Y

literal 0
HcmV?d00001

diff --git a/signwriting/visualizer/test_visualize.py b/signwriting/visualizer/test_visualize.py
index 1da025a..7d27d44 100644
--- a/signwriting/visualizer/test_visualize.py
+++ b/signwriting/visualizer/test_visualize.py
@@ -38,6 +38,22 @@ def test_image_invalid_fsw(self):
 
         assert_array_equal(np.array(image), np.array(reference_image))
 
+    def test_image_small_box(self):
+        fsw = "M500x500S2ff00407x501S1ce20436x535S2e300413x552S22b04418x565S36520420x523"
+
+        with self.assertRaises(ValueError):
+            signwriting_to_image(fsw)
+
+    def test_image_small_box_is_corrected(self):
+        fsw = "M500x500S2ff00407x501S1ce20436x535S2e300413x552S22b04418x565S36520420x523"
+
+        image = signwriting_to_image(fsw, trust_box=False)
+
+        assets_path = Path(__file__).parent / "test_assets" / f"{fsw}.png"
+        reference_image = Image.open(assets_path)
+
+        assert_array_equal(np.array(image), np.array(reference_image))
+
 
 if __name__ == '__main__':
     unittest.main()
diff --git a/signwriting/visualizer/visualize.py b/signwriting/visualizer/visualize.py
index 83ddc76..2428fc0 100644
--- a/signwriting/visualizer/visualize.py
+++ b/signwriting/visualizer/visualize.py
@@ -8,13 +8,20 @@
 
 
 @lru_cache(maxsize=None)
-def get_font(font_name: str):
+def get_font(font_name: str) -> ImageFont.FreeTypeFont:
     font_path = Path(__file__).parent / f'{font_name}.ttf'
     return ImageFont.truetype(str(font_path), 30)
 
 
+def get_symbol_size(symbol: str):
+    font = get_font('SuttonSignWritingLine')
+    line_id = symbol_line(key2id(symbol))
+    left, top, right, bottom = font.getbbox(line_id)
+    return right - left, bottom - top
+
+
 # pylint: disable=too-many-locals
-def signwriting_to_image(fsw: str, antialiasing=True) -> Image:
+def signwriting_to_image(fsw: str, antialiasing=True, trust_box=True) -> Image:
     sign = fsw_to_sign(fsw)
     if len(sign['symbols']) == 0:
         return Image.new('RGBA', (1, 1), (0, 0, 0, 0))
@@ -22,7 +29,17 @@ def signwriting_to_image(fsw: str, antialiasing=True) -> Image:
     positions = [s["position"] for s in sign['symbols']]
     min_x = min(positions, key=lambda p: p[0])[0]
     min_y = min(positions, key=lambda p: p[1])[1]
+
     max_x, max_y, = sign["box"]["position"]
+
+    if not trust_box:
+        max_x, max_y = 0, 0
+        for symbol in sign['symbols']:
+            symbol_x, symbol_y = symbol["position"]
+            symbol_width, symbol_height = get_symbol_size(symbol["symbol"])
+            max_x = max(max_x, symbol_x + symbol_width)
+            max_y = max(max_y, symbol_y + symbol_height)
+
     img = Image.new('RGBA', (max_x - min_x, max_y - min_y), (255, 255, 255, 0))
     draw = ImageDraw.Draw(img)
     if not antialiasing: