Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hid_get_feature_report broken on Windows XP #192

Open
nitsch opened this issue Oct 12, 2014 · 9 comments
Open

hid_get_feature_report broken on Windows XP #192

nitsch opened this issue Oct 12, 2014 · 9 comments

Comments

@nitsch
Copy link

nitsch commented Oct 12, 2014

The fix in commit 54eb31d breaks hid_get_feature_report() on Windows XP SP3. It worked previously, i.e. bytes_returned already included the additional byte for the report ID. I cannot test this on other versions of Windows. Maybe there are differences among them?
@nitsch
Copy link
Author

nitsch commented Oct 12, 2014

I got the problem verified on Windows 7, too. This was tested using MinGW.

OS: Windows 7 SP1, 64 bit
Compiler: http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/4.9.1/threads-posix/sjlj/

OS: Windows XP SP3, 32 bit
Compiler: http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win32/Personal%20Builds/mingw-builds/4.9.1/threads-posix/sjlj/

nitsch added a commit to nitsch/psmoveapi that referenced this issue Oct 13, 2014
@nitsch
Revert external/hidapi to an older commit
f33d67b 
The previous update to the latest hidapi upstream introduced changes that
break HID Feature report on Windows. This fix sets the hidapi submodule to
the commit preceeding the problematic one.

For a description of the problem see hidapi's issue list:

  signal11/hidapi#192
nitsch added a commit to nitsch/psmoveapi that referenced this issue Oct 13, 2014
@nitsch
Revert external/hidapi to an older commit
9f7ae8f 
The previous update to the latest hidapi upstream introduced changes that
break HID Feature reports on Windows. This fix sets the hidapi submodule to
the commit preceeding the problematic one.

For a description of the problem see hidapi's issue list:

  signal11/hidapi#192
@cboulay
Copy link

cboulay commented Nov 3, 2015

+1
This problem persists in Windows 8.1 and Windows 10. The exact same feature reports from the exact same devices return a different value in Windows than they do in Mac and Linux.

@cboulay
Copy link

cboulay commented Nov 3, 2015

By the way, here is the problematic commit. Edit: Oops, sorry, Alex already linked to the problematic commit in the first post.

@rbalik
Copy link

rbalik commented May 17, 2016

+1

@ZeusMinos
Copy link

So shall I revert this commit 54eb31d and done deal or other changes have to be done? BTW I clone master and that commit still present

@nitsch
Copy link
Author

nitsch commented Jun 16, 2016

What are you talking about? If this is about psmoveapi, please open a
ticket in their bug tracker and describe what exactly the problem is.

@mirh mirh mentioned this issue Jan 12, 2017
Open
@mirh
Copy link

mirh commented Jan 12, 2017

Is this fixed by #219 then?

@nitsch
Copy link
Author

nitsch commented Jan 12, 2017 via email

@mirh
Copy link

mirh commented Jan 12, 2017

The two things are related, considering that would also fix thp/psmoveapi#214

erikolofsson pushed a commit to Malterlib/hidapi that referenced this issue Nov 25, 2020
@Youw
add hid_version/hid_version_str API (signal11#192)
8f72236 
- API functions to get runtime version of the library;
- macros to get static/compile-time version of the library;
- VERSION file;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cboulay @nitsch @ZeusMinos @rbalik @mirh