You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm interested in providing a fix for this. Wondering what's the preferred solution for it? 1. Show a toast telling the user the passphrase is empty or 2. Abort the restoration operation altogether without telling the user anything. Similar to how it's done when the retrieved backup passphrase is empty. Personally I like option 1 as it gives info to the user why the restoration didn't happen at all.
I agree. Definitely solution 1. If the user has hit continue they most likely want to continue with the backup so reopening the prompt allows the process to be more streamlined for the user if they do not enter a passphrase.
eyedol
added a commit
to eyedol/Signal-Android
that referenced
this issue
Feb 25, 2025
…l chat backups
Introduces `PassphraseDialogManager` to handle the display and input of the backup passphrase dialog. This centralizes the passphrase dialog logic, improves code organization, and allows for easier management of error states and input validation. Updates `RestoreLocalBackupFragment` to use the new `PassphraseDialogManager`. Enables the dialog positive button only when input is not blank.
Guidelines
Bug description
Try to restore a backup chat without entering a passphrase. The restore is stuck during the
checking...
process.Screenshots
Device
Pixel 8 Prol
Android version
15
Signal version
7.35.0
Link to debug log
No response
The text was updated successfully, but these errors were encountered: