Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring chat backups without passphrase results in endless checking status #14015

Open
3 tasks done
eyedol opened this issue Feb 24, 2025 · 2 comments
Open
3 tasks done

Comments

@eyedol
Copy link
Contributor

eyedol commented Feb 24, 2025

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

Try to restore a backup chat without entering a passphrase. The restore is stuck during the checking... process.

Screenshots

Device

Pixel 8 Prol

Android version

15

Signal version

7.35.0

Link to debug log

No response

@eyedol
Copy link
Contributor Author

eyedol commented Feb 24, 2025

I'm interested in providing a fix for this. Wondering what's the preferred solution for it? 1. Show a toast telling the user the passphrase is empty or 2. Abort the restoration operation altogether without telling the user anything. Similar to how it's done when the retrieved backup passphrase is empty. Personally I like option 1 as it gives info to the user why the restoration didn't happen at all.

@m4rsland1498
Copy link

I agree. Definitely solution 1. If the user has hit continue they most likely want to continue with the backup so reopening the prompt allows the process to be more streamlined for the user if they do not enter a passphrase.

eyedol added a commit to eyedol/Signal-Android that referenced this issue Feb 25, 2025
…l chat backups

Introduces `PassphraseDialogManager` to handle the display and input of the backup passphrase dialog. This centralizes the passphrase dialog logic, improves code organization, and allows for easier management of error states and input validation. Updates `RestoreLocalBackupFragment` to use the new `PassphraseDialogManager`. Enables the dialog positive button only when input is not blank.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants