Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pls Add sort & direction additional parameters #21

Open
JayKandari opened this issue Feb 10, 2016 · 1 comment
Open

Pls Add sort & direction additional parameters #21

JayKandari opened this issue Feb 10, 2016 · 1 comment

Comments

@JayKandari
Copy link

Hi Tyler, Grt Job with this module. I myself learned a lot. I was trying to node_index(query) from drupal when I discovered the code doesn't have sort & direction parameter in "drupal_entity_index_build_query_string()" if you can see that in 7.x version. Thanks. !!

Attached is a screenshot of Drupal Services Entity module with its additional parameters.

This will make query builder complete. :) Thanks
screenshot-www drupal org 2016-02-10 16-24-52

@signalpoint
Copy link
Owner

@JayKandari Hello, thank you for the kind words. We actually don't use the Services Entity module, but this functionality is now baked into the Services module. See this fixed issue for an explanation of how to use sorts: https://www.drupal.org/node/2537968

This feature needs to be now baked into Angular Drupal. I've implemented this feature in jDrupal here: https://github.com/easystreet3/jDrupal/blob/7.x-1.x/src/services/services.entity.js#L225

So ideally Angular Drupal would be expanded to have a similar entity_index function like jDrupal. That code would go here: https://github.com/easystreet3/angular-drupal/blob/7.x-1.x/src/angular-drupal.js#L465

And that function would be intelligent enough to assemble the proper query string. I'm gladly accepting pull requests on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants