Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests #8

Open
1 of 5 tasks
danilowoz opened this issue Oct 2, 2018 · 3 comments
Open
1 of 5 tasks

Missing tests #8

danilowoz opened this issue Oct 2, 2018 · 3 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@danilowoz
Copy link
Contributor

danilowoz commented Oct 2, 2018

Currently, we don't have any test and I really want to ensure that everything keeps working fine on the future changes and avoid bugs in the application. However, It's a great opportunity to learn and improve the skills to build tests in React.

What are we expecting?

  • Choose the best suit test (Jest, chai, whatever you prefer);
  • Split the code into smaller parts;
  • 100% coverage or close that;
  • Improv the Flow type;
  • Don't change and don't remove any feature;

Cheers 🍻

@danilowoz danilowoz added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 2, 2018
@takethefake
Copy link

Will take care of this!

takethefake pushed a commit to takethefake/react-snuggle that referenced this issue Oct 2, 2018
@takethefake
Copy link

I've chosen Jest + react-testing-library for testing.

I would split the rendering of the grid in a single component and the rendering of each tile in a component.

Was wondering what edge cases are extremely important with this library to create coverage with meaningful tests.

@danilowoz
Copy link
Contributor Author

Thanks, @takethefake, the setup is almost done.
I think we can to keep this issue open and improve the tests.

To the next contributors, there is a todo list at the top of the discussion and any doubt or needs help, just message here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Development

No branches or pull requests

2 participants