Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language code resolution endpoint #274

Closed
johnml1135 opened this issue Jan 17, 2024 · 4 comments
Closed

Language code resolution endpoint #274

johnml1135 opened this issue Jan 17, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request requirement

Comments

@johnml1135
Copy link
Collaborator

johnml1135 commented Jan 17, 2024

Endpoint: translation/languages

Input:

  • engineType: string
  • languageCode: string
  • engineModel (optional): string (future)

Output:

  • resolvedLanguageCode: string
  • nativeSupportInModel: T/F
@johnml1135 johnml1135 self-assigned this Jan 17, 2024
@johnml1135 johnml1135 added enhancement New feature or request requirement labels Jan 17, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Jan 17, 2024
@johnml1135
Copy link
Collaborator Author

@Nateowami, @pmachapman (CC @ddaspit ) - what exactly do you want to use this for? Is there any other information that you would want to use?

  • If you want to only use it after an engine is created, we could just give the resolved or supported field in corpora or engine fields
  • Are you wanting which scripts are supported in a language?
  • Is there any other information that you would want?

@Nateowami
Copy link
Collaborator

@johnml1135 I can't give an exhaustive list of everything we might want it for (Peter would be better at coming up with use cases), but we absolutely need it before an engine is created so we can tell the user whether their project is supported.

And Peter saw some utility in specifying which language code it maps to, rather than just whether it's a supported language.

@pmachapman
Copy link
Collaborator

The primary use case I can think of is to verify that a language is supported by Serval before creating the engine. resolvedLanguageCode would be helpful to see what it maps to.

@johnml1135 johnml1135 moved this from 🆕 New to 🏗 In progress in Serval Jan 19, 2024
@johnml1135
Copy link
Collaborator Author

#283

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Serval Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requirement
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants