Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ses.downloadURL(url) #104

Open
sindresorhus opened this issue Feb 5, 2020 · 2 comments
Open

Use ses.downloadURL(url) #104

sindresorhus opened this issue Feb 5, 2020 · 2 comments
Labels
enhancement help wanted

Comments

@sindresorhus
Copy link
Owner

Electron 8 added a new useful API: https://github.com/electron/electron/pull/19889/files

We should use it for electronDl.download().
@sindresorhus sindresorhus mentioned this issue Feb 5, 2020
Closed
@mquevill mquevill mentioned this issue Sep 15, 2021
Closed
@sindresorhus
Copy link
Owner Author

If anyone wants to work on this, see the initial attempt in #138

@sindresorhus sindresorhus pinned this issue Dec 10, 2022
@mquevill
Copy link
Contributor

It seems like using webContents.downloadURL is the preferred method according to Electron's session docs:

Note: This does not perform any security checks that relate to a page's origin, unlike webContents.downloadURL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use session API to download files mquevill/electron-dl
2 participants
@sindresorhus @mquevill