Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated tags in probset #466

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

segir187
Copy link
Contributor

@segir187 segir187 commented Feb 21, 2025

Resolves #459.

@segir187
Copy link
Contributor Author

segir187 commented Feb 21, 2025

I have a couple of things I have yet to implement and would appreciate feedback on - I'd like to make the maximum amount of proposed tags displayed for any given problem to be configurable, as well as the minimum amount of proposals for any given tag to be displayed as a proposed tag.

How should I go about implementing such configurability? Should these just be constants in settings.py or elsewhere? Should it be possible for admins to increase / decrease these values for any given task with constant default values?

@segir187
Copy link
Contributor Author

How about the way the proposed tags are displayed? Should they appear with or without their amounts?
If with their amounts, how could I make the way they're displayed more pleasing to the eye?
The current way of separating the tag name from its amount with a | symbol works well enough for the admin panel, but seems too unpolished for displaying in public.

@segir187
Copy link
Contributor Author

Should the displaying of these proposed tags be configurable in settings? As in, should there be a constant boolean value in settings.py saying whether to give users the option to display tag proposals when displaying tags in the probset?

Right now the option is available by default if tags are shown in the probset. Maybe I should make the appearance of this option contingent on the ability of users to submit tag proposals after solving tasks?

@segir187
Copy link
Contributor Author

And finally, what sorts of tests should I add for this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional way to see aggregated tag proposals in probset for all users.
2 participants