Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Parpoiled's ASM transitive dependency #226

Open
RobWin opened this issue Mar 30, 2016 · 1 comment
Open

Problems with Parpoiled's ASM transitive dependency #226

RobWin opened this issue Mar 30, 2016 · 1 comment

Comments

@RobWin
Copy link

RobWin commented Mar 30, 2016

Hello,

the ASM library dependency of Parboiled causes issues, if you use Pegdown in a project which requires ASM in a different (lower) version. For example: markdown-asciidoc/markdown-to-asciidoc#24

Is there a possibility to release a Pegdown version which shadows Parboiled and its transitive dependencies? Means: To package the Pegdown in an uber-jar, including its dependencies and to shade - i.e. rename - the packages of some of the dependencies.

With Maven you could use https://maven.apache.org/plugins/maven-shade-plugin/.
With Gradle you could use https://github.com/johnrengelman/shadow

Not sure if there is a plugin for SBT though :(

@RobWin RobWin changed the title Problems with Parpoiled's ASM transitive dependency Problems with Parpoiled's ASM (transitive dependency) Mar 30, 2016
@RobWin RobWin changed the title Problems with Parpoiled's ASM (transitive dependency) Problems with Parpoiled's ASM transitive dependency Mar 30, 2016
@vsch
Copy link
Contributor

vsch commented Dec 13, 2016

@RobWin, when I used to use pegdown in my IntelliJ plugin, I resorted to using jarjar to change parboiled ASM dependency to a customized package so it does not conflict with other ASM lib versions.

Could be an easy solution for you too. Here is what I used in my jarjar.rules file:

rule org.objectweb.asm.** com.vladsch.asm4.@1

And the bash script to run jarjar:

#!/usr/bin/env bash
java -jar jarjar-1.4.jar process jarjar.rules asm-all-4.1.jar ../lib/asm-all-asm4.jar
java -jar jarjar-1.4.jar process jarjar.rules parboiled-java-1.1.7.jar ../lib/parboiled-java-asm4.jar
java -jar jarjar-1.4.jar process jarjar.rules parboiled-java-1.1.7.jar ../lib/parboiled-java-asm4.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants