Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] QPD_B mean and var fail due to numeric instability #257

Closed
fkiraly opened this issue Apr 19, 2024 · 2 comments
Closed

[ENH] QPD_B mean and var fail due to numeric instability #257

fkiraly opened this issue Apr 19, 2024 · 2 comments
Labels
bug module:probability&simulation probability distributions and simulators

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Apr 19, 2024

QPD_B is failing internally, it is substituting 0 or 1 into a logit, which produces nans.

To reproduce, run check_estimator on QPD_B, it is failing for the supplied examples.

Any ideas where or why, @FelixWick, @setoguchi-naoki?
@fkiraly fkiraly added bug module:probability&simulation probability distributions and simulators labels Apr 19, 2024
@fkiraly fkiraly mentioned this issue Apr 19, 2024
Merged
@fkiraly fkiraly changed the title [ENH] QPD_B mean and var fail [ENH] QPD_B mean and var fail due to numeric instability Apr 19, 2024
fkiraly added a commit that referenced this issue Apr 19, 2024
@fkiraly
[BUG] bugfixes to QPD distributions - QPD_U, QPD_S (#194)
d37092f 
Re-enables tests for `QPD_U`, `QPD_S` skipped in #193 and
attempts to fix failures in QPD distributions.

it appears that #190 failures are resolved - fixes #190.

Further `QPD_B` seems to fail at mean and var calculations, this is a
separate bug and raised as #257.
As a mechanical consequence, `QPD_B` is left skipped in the tests.
@fkiraly fkiraly mentioned this issue Apr 19, 2024
Merged
5 tasks
@FelixWick
Copy link

We are still calling the extended versions for J-QPD-S and J-QPD-B. Since I have only updated the non-extended to work vectorized, I would suggest to switch to these. (This might also fix this issue.)

@fkiraly
Copy link
Collaborator Author

fkiraly commented May 22, 2024

Resolved by #327

@fkiraly fkiraly closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug module:probability&simulation probability distributions and simulators
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FelixWick @fkiraly