Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: deploy indicates success when nothing was deployed #229

Open
techfg opened this issue Sep 27, 2024 · 0 comments
Open

bug: deploy indicates success when nothing was deployed #229

techfg opened this issue Sep 27, 2024 · 0 comments

Comments

@techfg
Copy link

techfg commented Sep 27, 2024

When executing deploy, several situations can occur with the command indicating success in the logs but resulting in nothing being deployed.

The situations are:

  1. The targetDirectory exists but is empty
  2. The targetDirectory exists, is not empty, but contains no valid metadata files
  3. The server returned valid JSON from GetDeployPlan but did not return a skuidMetadataService plan or a skuidCloudDataService plan

Regardless of which of the situations above occur, the user should be informed in an appropriate way (warning indicating nothing deployed and/or outright error) as currently, they could think their entire site deployed but nothing deployed.

Bonus item: When GetDeployPlan returns valid JSON and it contains a plan for skuidMetadataService and/or skuidCloudDataService but the plan doesn't contain complete information (e.g., missing the Host or Endpoint), the error emitted to the logs is HTTP 404 Not Found which is rather meaningless to a user so this error could be improved.

techfg added a commit to techfg/skuid-cli that referenced this issue Oct 5, 2024
Note that some issues mentioned in skuid#229 were addressed inaf20e1e74ff14ee0bfeab32a2c95f060670fe3a0 or prior commits in skuid#205
Resolves skuid#229
Related af20e1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant