From d9547d85ac77278f6ee62818ac16c436c6d4753c Mon Sep 17 00:00:00 2001 From: Kenneth Giusti Date: Wed, 28 Feb 2024 08:41:06 -0500 Subject: [PATCH 1/2] Fixes #1427: update codecov/codecov-action v4 API Closes #1427 --- .github/workflows/build.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 2263cebae..c02ed7ea6 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -797,17 +797,18 @@ jobs: if: ${{ !cancelled() && matrix.buildType == 'Coverage' }} working-directory: ${{env.RouterBuildDir}} run: | - dnf install -y lcov + dnf install -y lcov git cmake --build . --target coverage # https://github.com/codecov/codecov-action - name: Upload C Coverage if: ${{ !cancelled() && matrix.buildType == 'Coverage' }} uses: codecov/codecov-action@v4 + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} with: flags: ${{matrix.covType}}tests verbose: true - gcov: true name: skupper-router root_dir: . working-directory: ${{github.workspace}}/skupper-router @@ -822,6 +823,8 @@ jobs: - name: Upload Python Coverage if: ${{ !cancelled() && matrix.buildType == 'Coverage' }} uses: codecov/codecov-action@v4 + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} with: flags: py${{matrix.covType}}tests verbose: true From 10dccd47e9701bb5a37dbd99db0a257fd322713c Mon Sep 17 00:00:00 2001 From: Kenneth Giusti Date: Wed, 28 Feb 2024 10:25:02 -0500 Subject: [PATCH 2/2] guess: error finding root folder? --- .github/workflows/build.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index c02ed7ea6..8458f007e 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -810,7 +810,6 @@ jobs: flags: ${{matrix.covType}}tests verbose: true name: skupper-router - root_dir: . working-directory: ${{github.workspace}}/skupper-router - name: Process Python coverage @@ -830,7 +829,6 @@ jobs: verbose: true directory: ${{env.RouterBuildDir}}/tests name: skupper-router - root_dir: . working-directory: ${{github.workspace}}/skupper-router - name: Report coredump stacktraces (if any tests failed)