-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of deprecation warning to change content_type to media_type in Rails 6 #142
Comments
Thanks @siruguri. We have a branch in progress that will fix this issue, and will notify you here when it has been released. |
@siruguri in the meantime you can silence the warnings and return to the previous behavior of |
@zvkemp I've just tried upgrading an application to Rails v6, and just a heads up, that setting doesn't seem to disable the deprecation warning. (Also removing the skylight gem, removed the deprecation warnings, so I'm pretty sure there wasn't some other culprit). |
This is fixed as of Skylight 4.2.0-beta (current prerelease version is 4.2.0-beta3). @olly Could you let me know what version(s) of Skylight you tried, and could you confirm that you fully restarted your application after making that config change? |
@zvkemp you're right. I think I must have had some weird interaction with the |
I am seeing this error in my app while I test upgrading to Rails 6.0.0.rc2
The relevant line does this:
type_str = content_type.to_s.split(';').first
The text was updated successfully, but these errors were encountered: