Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Module membership declarations are not supported in the grammar #70

Open
3 tasks done
mmanela opened this issue May 22, 2024 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@mmanela
Copy link

mmanela commented May 22, 2024

Describe the bug

Module membership declarations are not support in the grammar

Requirements

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

To Reproduce

Grammar does not support module membership declarations which prevents a highlighting query from targeting them.

module foo;

Which currently parses as the following (notice the ERROR)

(expression_statement  
    (qualified_identifier  
      (identifier)) 
    (ERROR 
      (identifier)))

Expected behavior

I expect the module membership declarations to parse properly.

@mmanela mmanela added the bug Something isn't working label May 22, 2024
@mmanela mmanela changed the title [BUG] Module membership declarations are not support in the grammar [BUG] Module membership declarations are not supported in the grammar May 31, 2024
mmanela added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this issue Jul 30, 2024
Adds scip-ctags support for the Hack language.  

Noteworthy items
1. I did not add support for modules since they are [not
supported](slackhq/tree-sitter-hack#70) in the
tree-sitter grammar right now.


## Screenshots

![image](https://github.com/user-attachments/assets/5c75a0c3-4b88-4e20-a2be-82e04a89791c)

## Test plan
- [x] Update unit tests
- [x] Manually validate symbol side bar for indexed commits
- [x] Manually validate symbol side bar for unindexed commits
- [x] Validate symbol search for indexed commits
- [x] Validate symbol search for unindexed commits
burmudar pushed a commit to sourcegraph/sourcegraph-public-snapshot that referenced this issue Jul 31, 2024
Adds scip-ctags support for the Hack language.  

Noteworthy items
1. I did not add support for modules since they are [not
supported](slackhq/tree-sitter-hack#70) in the
tree-sitter grammar right now.


## Screenshots

![image](https://github.com/user-attachments/assets/5c75a0c3-4b88-4e20-a2be-82e04a89791c)

## Test plan
- [x] Update unit tests
- [x] Manually validate symbol side bar for indexed commits
- [x] Manually validate symbol side bar for unindexed commits
- [x] Validate symbol search for indexed commits
- [x] Validate symbol search for unindexed commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant