You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mmanela
changed the title
[BUG] Module membership declarations are not support in the grammar
[BUG] Module membership declarations are not supported in the grammar
May 31, 2024
Adds scip-ctags support for the Hack language.
Noteworthy items
1. I did not add support for modules since they are [not
supported](slackhq/tree-sitter-hack#70) in the
tree-sitter grammar right now.
## Screenshots
![image](https://github.com/user-attachments/assets/5c75a0c3-4b88-4e20-a2be-82e04a89791c)
## Test plan
- [x] Update unit tests
- [x] Manually validate symbol side bar for indexed commits
- [x] Manually validate symbol side bar for unindexed commits
- [x] Validate symbol search for indexed commits
- [x] Validate symbol search for unindexed commits
burmudar
pushed a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this issue
Jul 31, 2024
Adds scip-ctags support for the Hack language.
Noteworthy items
1. I did not add support for modules since they are [not
supported](slackhq/tree-sitter-hack#70) in the
tree-sitter grammar right now.
## Screenshots
![image](https://github.com/user-attachments/assets/5c75a0c3-4b88-4e20-a2be-82e04a89791c)
## Test plan
- [x] Update unit tests
- [x] Manually validate symbol side bar for indexed commits
- [x] Manually validate symbol side bar for unindexed commits
- [x] Validate symbol search for indexed commits
- [x] Validate symbol search for unindexed commits
Describe the bug
Module membership declarations are not support in the grammar
Requirements
To Reproduce
Grammar does not support module membership declarations which prevents a highlighting query from targeting them.
Which currently parses as the following (notice the ERROR)
Expected behavior
I expect the module membership declarations to parse properly.
The text was updated successfully, but these errors were encountered: