Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SmallRyeHealthReporter init into the post construct method #602

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

xstefank
Copy link
Member

@xstefank xstefank commented Jan 8, 2025

Fixes #562

@gsmet, if you look into this, I discussed it with @mkouba, and singleton is not a good idea because of various problems, mostly in WildFly integration. But at least I moved all initialization to post-construct.

@xstefank xstefank requested a review from jmartisk January 8, 2025 09:09
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xstefank xstefank merged commit 998db2d into smallrye:main Jan 8, 2025
7 checks passed
@xstefank
Copy link
Member Author

xstefank commented Jan 8, 2025

Thanks @mkouba

@github-actions github-actions bot added this to the 4.1.2 milestone Jan 8, 2025
@gsmet
Copy link

gsmet commented Jan 8, 2025

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we optimize SmallRyeHealthReporter initialization a bit?
3 participants